Corrected Date of Resupply Interception Scenarios & Added Clarity to Scenario Names #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified multiple methods to include an optional `daysTilDeployment` parameter for specifying scenario deployment timelines. This enhances flexibility by allowing dynamic or fixed deployment dates based on gameplay needs. Also updated related logic to ensure proper scenario setup and date persistence.
IllianiCBT
added
Bug
StratCon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5466 +/- ##
=========================================
Coverage 10.11% 10.11%
- Complexity 6071 6077 +6
=========================================
Files 1054 1054
Lines 140535 140551 +16
Branches 20419 20424 +5
=========================================
+ Hits 14214 14221 +7
- Misses 124964 124972 +8
- Partials 1357 1358 +1 ☔ View full report in Codecov by Sentry. |
Modified `generateScenario` to include an optional `daysTilDeployment` parameter, allowing scenarios to account for deployment delays. Improved documentation to clarify functionality and integration with the campaign and StratCon tracks.
HammerGS
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified multiple methods to include an optional
daysTilDeploymentparameter for specifying scenario deployment timelines. This enhances flexibility by allowing dynamic or fixed deployment dates based on gameplay needs. It also ensures the date resupply interceptions announce in the command log will also match the date in which they take place.Also updated scenario names for convoy interception scenarios. If a player convoy is intercepted, the convoy's name will appear in the scenario name.
Fixes #5465