Reassigned StratCon Force Assignment Picker as Modal #5354
+15
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplified variable declarations and refactored the actionPerformed method by replacing the switch statement with an if condition. Added setModal(true) to enforce modal behavior for the dialog. These changes improve code clarity, consistency, and user experience.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5354 +/- ##
============================================
- Coverage 10.47% 10.45% -0.02%
+ Complexity 6069 6055 -14
============================================
Files 959 959
Lines 135559 135590 +31
Branches 19750 19754 +4
============================================
- Hits 14204 14181 -23
- Misses 119997 120053 +56
+ Partials 1358 1356 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setModal(true) to enforce modal behavior for the Manage Force Assignment dialog.
Simplified variable declarations and refactored the
actionPerformedmethod by replacing the switch statement with an if condition.Closes #5345