Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BriefingTab Fix #5272

Merged
merged 1 commit into from
Dec 3, 2024
Merged

BriefingTab Fix #5272

merged 1 commit into from
Dec 3, 2024

Conversation

DM0000
Copy link
Contributor

@DM0000 DM0000 commented Dec 2, 2024

Bad behavior on canceling "Add Mission" was due to single boolean check if mission was contract. If add mission tab was closed it would default to false and CustomizeMissionDialog frame would be generated.
-- added isMission() check

Also set briefing tab to remain visible.

Add mission check to AddMission and left BriefTab visible
closes #5060

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.47%. Comparing base (d333f62) to head (427e379).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5272   +/-   ##
=========================================
  Coverage     10.47%   10.47%           
- Complexity     6049     6050    +1     
=========================================
  Files           959      959           
  Lines        135202   135201    -1     
  Branches      19674    19675    +1     
=========================================
  Hits          14165    14165           
+ Misses       119686   119684    -2     
- Partials       1351     1352    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit ae6042d into MegaMek:master Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.01-2024-10-18] Bad behavior on canceling "Add Mission"
4 participants