Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null checks in manual contract generation #5270

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

DM0000
Copy link
Contributor

@DM0000 DM0000 commented Dec 2, 2024

closes #5149

Added null checks for Employer, Enemy, and Planet with matching messages.

image
image

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.47%. Comparing base (d1b53f6) to head (d333f62).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##             master    #5270    +/-   ##
==========================================
  Coverage     10.47%   10.47%            
- Complexity     6039     6049    +10     
==========================================
  Files           959      959            
  Lines        135067   135202   +135     
  Branches      19650    19674    +24     
==========================================
+ Hits          14147    14165    +18     
- Misses       119569   119686   +117     
  Partials       1351     1351            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit de87aeb into MegaMek:master Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] Better error message for null values in contract fields
3 participants