Added initiativeMaxBonus to Campaign #5260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -690,6 +690,8 @@ | |||
| retVal.setCrimeRating(Integer.parseInt(wn.getTextContent())); | |||
| } else if (xn.equalsIgnoreCase("initiativeBonus")) { | |||
| retVal.setInitiativeBonus(Integer.parseInt(wn.getTextContent())); | |||
| } else if (xn.equalsIgnoreCase("initiativeMaxBonus")) { | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5260 +/- ##
============================================
- Coverage 10.50% 10.48% -0.02%
- Complexity 6041 6052 +11
============================================
Files 957 959 +2
Lines 134738 135082 +344
Branches 19578 19653 +75
============================================
+ Hits 14149 14170 +21
- Misses 119234 119560 +326
+ Partials 1355 1352 -3 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added initiativeMaxBonus to Campaign with XML support
added maxBonus check to initiativeIncrementer
added applyInitiativeBonus() to adjust initiativeMax and apply appropriate bonus
added initiative tests
Ref #4600