Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds null check before accessing skill property #5252

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Nov 26, 2024

I dont know of any bug in particular that called for this, however when checking the save from the issue #4529 I encountered this error, where it was looking for a specific skill that the person didnt had loaded, so when trying to open the person contextual menu it threw a null pointer exception.

@Scoppio Scoppio self-assigned this Nov 26, 2024
@Scoppio Scoppio requested a review from IllianiCBT November 26, 2024 01:35
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.49%. Comparing base (519101f) to head (318ec88).
Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5252      +/-   ##
============================================
- Coverage     10.50%   10.49%   -0.01%     
  Complexity     6044     6044              
============================================
  Files           957      957              
  Lines        134716   134726      +10     
  Branches      19572    19578       +6     
============================================
- Hits          14149    14144       -5     
- Misses       119216   119228      +12     
- Partials       1351     1354       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 0f0c41b into MegaMek:master Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants