Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4849: Replaced Cubicles Persist after Saving & Loading #5251

Merged

Conversation

psikomonkie
Copy link
Collaborator

@psikomonkie psikomonkie commented Nov 25, 2024

Fixes #4849

Same fix was used on the MissingBayDoor class.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.50%. Comparing base (519101f) to head (7083ed4).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5251   +/-   ##
=========================================
  Coverage     10.50%   10.50%           
- Complexity     6044     6045    +1     
=========================================
  Files           957      957           
  Lines        134716   134726   +10     
  Branches      19572    19577    +5     
=========================================
+ Hits          14149    14151    +2     
- Misses       119216   119226   +10     
+ Partials       1351     1349    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psikomonkie
Copy link
Collaborator Author

fixes #4849

@HammerGS HammerGS merged commit 8c19ce2 into MegaMek:master Nov 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I customized an Overlord Dropship by removing some bay doors it shows up damaged
3 participants