Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced INVALID Formation Level Checking #5217

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Expanded the case matching for the INVALID formation level to include the string "Invalid Formation". This prevents invalid formations from failing to parse.

Closes #5204

Expanded the case matching for the INVALID formation level to include the string "Invalid Formation". This improves robustness in identifying invalid formation levels in the system.
@IllianiCBT IllianiCBT added the Bug label Nov 19, 2024
@IllianiCBT IllianiCBT self-assigned this Nov 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.52%. Comparing base (bce5f63) to head (06ba17f).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5217   +/-   ##
=========================================
  Coverage     10.52%   10.52%           
- Complexity     6047     6053    +6     
=========================================
  Files           957      957           
  Lines        134523   134523           
  Branches      19545    19545           
=========================================
+ Hits          14154    14161    +7     
+ Misses       119018   119014    -4     
+ Partials       1351     1348    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit 90ba6c1 into MegaMek:master Nov 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MEKHQ V.50.01] TO&E forces wiped on campgain load
3 participants