Reworked AtB Morale, Rebranding it as MekHQ Morale #4859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked AtB Morale removing some of the rough edges, adding full documentation, and better integrating it into StratCon. It is my hope this revised system will remove some instances of the 'one bad roll' death spirals that the old system suffered from.
IllianiCBT
commented
Sep 19, 2024
| AtBMoraleLevel.VERY_HIGH.toolTipText=The unit is dedicated to their cause. | ||
| AtBMoraleLevel.UNBREAKABLE.text=Unbreakable | ||
| AtBMoraleLevel.UNBREAKABLE.toolTipText=The unit's trust in their leadership and dedication to their cause is nigh-on unbreakable, and they look forward to fighting their enemies. | ||
| AtBMoraleLevel.ROUTED.text=Routed |
There was a problem hiding this comment.
I opted to rename the levels for three reasons:
- to add distance from official morale rules, so there can be no confusion that this is unofficial
- to better reflect how we're currently using these morale levels, as not just a measurement of enemy mental wellbeing, but also material capacity to fight back.
- with some of the other user-facing terminology changes, this helps give the illusion of fighting a persistent enemy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4859 +/- ##
==========================================
Coverage 10.45% 10.45%
- Complexity 5978 6011 +33
==========================================
Files 953 953
Lines 132333 132712 +379
Branches 19206 19308 +102
==========================================
+ Hits 13833 13881 +48
- Misses 117172 117487 +315
- Partials 1328 1344 +16 ☔ View full report in Codecov by Sentry. |
|
Has conflicting files. |
# Conflicts: # MekHQ/src/mekhq/campaign/Campaign.java # MekHQ/src/mekhq/campaign/mission/AtBContract.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked AtB Morale removing some of the rough edges, adding full documentation, and better integrating it into StratCon.
It is my hope this revised system will remove some instances of the 'one bad roll' death spirals that the old system suffered from.