Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3775: unable to assign nonsuperheavy crew #3855

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Feb 24, 2024

Includes a couple of fixes for non-standard Mek crew complements:

  1. Non-SH Tripods can now be assigned to crews, or have crews assigned to them.
  2. Pilots can be assigned to SH and Tripods in the Personnel tab (previously broken)

Testing:

  • Ran all unit tests across 3 projects (several still failing in MekHQ, unrelated)
  • Tested crew assignments in a campaign with both SuperHeavy and Medium Tripod meks.

Close #3775

@SJuliez
Copy link
Member

SJuliez commented Feb 26, 2024

Are the failed tests important?

@Sleet01
Copy link
Collaborator Author

Sleet01 commented Feb 26, 2024

Are the failed tests important?

Negative; these are the refit tests that I fixed later:

RefitTest > fleaFLE4toFLE15Test() FAILED
    org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
...
RefitTest > locust1Vto1ETest() FAILED
    org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
...
RefitTest > heavyTrackedApcMgToStandard() FAILED
    org.opentest4j.AssertionFailedError: expected: <1> but was: <0>

@SJuliez SJuliez merged commit 26fb8cf into MegaMek:master Feb 27, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.15] Unable to assign pilot and gunner to standard-weight tripod battlemechs
2 participants