Partial fix for failing refit tests #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3853 +/- ##
============================================
- Coverage 10.62% 10.62% -0.01%
Complexity 5472 5472
============================================
Files 834 834
Lines 113881 113885 +4
Branches 17203 17203
============================================
Hits 12097 12097
- Misses 100576 100580 +4
Partials 1208 1208 ☔ View full report in Codecov by Sentry. |
|
This now fixes all currently-failing MekHQ tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let some of the refit unit tests pass; we've seen that more tests need the EquipmentTypes initialized in recent months. Note that this does not fix the issues related to Machine Gun Ammo bins.