Simplified resupply smuggler message formatting.

Refactored the message generation to combine the value string directly within the formatted output. This reduces intermediate variables and improves code clarity.
MegaMek · Dec 21, 2024 · 08dd0b1 · 08dd0b1
1 parent 9c87518
commit 08dd0b1
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/MekHQ/src/mekhq/gui/dialog/resupplyAndCaches/DialogItinerary.java b/MekHQ/src/mekhq/gui/dialog/resupplyAndCaches/DialogItinerary.java
@@ -319,16 +319,14 @@ private static String getInitialDescription(Resupply resupply) {
                 yield String.format(message, value);
             }
             case RESUPPLY_SMUGGLER -> {
-                String message = String.format(
-                    resources.getString("guerrillaSupplies" + randomInt(25) + ".text"),
-                    campaign.getCommanderAddress(true), getEnemyFactionReference(resupply),
-                    resupply.getConvoyContentsValueCalculated().toAmountAndSymbolString());
-
                 String value = String.format(resources.getString("supplyCostFull.text"),
                     resupply.getConvoyContentsValueCalculated().toAmountAndSymbolString(),
                     resupply.getConvoyContentsValueBase().toAmountAndSymbolString());
 
-                yield String.format(message, value);
+                yield String.format(
+                    resources.getString("guerrillaSupplies" + randomInt(25) + ".text"),
+                    campaign.getCommanderAddress(true), getEnemyFactionReference(resupply),
+                    resupply.getConvoyContentsValueCalculated().toAmountAndSymbolString(), value);
             }
         };
     }