Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inverted function call #1665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Scoppio
Copy link
Collaborator

@Scoppio Scoppio commented Dec 14, 2024

This Pull request is part of an overarching change on Megamek to extract an options interface.
This pull request depends on the PR of the same name on Megamek, which adds the inverted call for this function.

Related

MegaMek/megamek#6265

@Scoppio Scoppio force-pushed the game-options-interface branch from ab12674 to 2dd4712 Compare December 14, 2024 03:41
@Scoppio Scoppio force-pushed the game-options-interface branch from 2dd4712 to 5ea027b Compare December 14, 2024 03:46
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but it would be nice to have some info in the comment, or a link to a central PR if this is part of a larger set of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants