Issue 6373: Fixed "unit that starts and ends a Movement Phase in liquid magma takes an additional damage" so it doesn't apply to units above the magma #6419
+13
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id magma takes an additional damage" so it doesn't apply to units above the magma (vtol, hover, bridge) and so units can't avoid it by standing still.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6419 +/- ##
=========================================
Coverage 28.53% 28.53%
- Complexity 14089 14090 +1
=========================================
Files 2792 2792
Lines 273746 273746
Branches 48492 48492
=========================================
+ Hits 78102 78104 +2
+ Misses 191664 191661 -3
- Partials 3980 3981 +1 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
…ma damage at the start of the round. Instead, let's track if it took magma damage at the start of the round.
|
Hey! This is ready for review. Thanks! |
HammerGS
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 6373: Fixed "unit that starts and ends a Movement Phase in liquid magma takes an additional damage" so it doesn't apply to units above the magma (vtol, hover, bridge) and so units can't avoid it by standing still.
Fixes #6373
I moved the extra damage for starting & ending a turn inside magma from inside of processSteps(), which won't do much if you don't take any steps, to after it finishes processing all of the steps. Finally, it properly checks if the unit is actually in the magma, or above the magma (Vtol, hovering, bridge).