Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5984 - Prevent 0 CF bridges in generated maps #6026

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Sep 21, 2024

This uses a default CF of 40 in generated maps when random map settings (or some other thing) would otherwise lead to 0 CF bridges.

Fixes #5984

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.09%. Comparing base (036eda5) to head (f4de423).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6026   +/-   ##
=========================================
  Coverage     29.09%   29.09%           
- Complexity    13972    13973    +1     
=========================================
  Files          2580     2580           
  Lines        267172   267174    +2     
  Branches      47710    47711    +1     
=========================================
+ Hits          77744    77745    +1     
- Misses       185530   185532    +2     
+ Partials       3898     3897    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit 7beb861 into MegaMek:master Sep 22, 2024
6 checks passed
@SJuliez SJuliez deleted the prevent-0-cf-bridges branch October 15, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

50.00 - Map Generator generates 0 CF bridges that collapse on Turn 1.
2 participants