Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged duplicated key 'deployment' in the Mad Cat Bounty Hunter MTF #5761

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

juk0de
Copy link
Contributor

@juk0de juk0de commented Jul 21, 2024

This PR merges the two deployment keys in the "Mad Cat (Timber Wolf) (Bounty Hunter)" MTF file into a single one.

It's another issue I noticed while testing my MTF to JSON converter. This is literally the only biped mech MTF file that contains two deployment keys, therefore I assume that it's a bug and not intended.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.08%. Comparing base (aa26b46) to head (bd3e4fd).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5761   +/-   ##
=========================================
  Coverage     29.08%   29.08%           
- Complexity    13901    13906    +5     
=========================================
  Files          2507     2507           
  Lines        266193   266193           
  Branches      47594    47594           
=========================================
+ Hits          77411    77417    +6     
+ Misses       184860   184857    -3     
+ Partials       3922     3919    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 2e61536 into MegaMek:master Jul 21, 2024
5 of 6 checks passed
@juk0de juk0de deleted the fix_bounty_hunter_deploy_key branch July 22, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants