feat: Implement left navigation level 1 for sites - EXO-65477 - Meeds-io/MIPs#72 #2771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GouadriaHanen
force-pushed
the
EXO-65477
branch
2 times, most recently
from
ac99c0a
to
c5c975b
Compare
GouadriaHanen
force-pushed
the
EXO-65477
branch
4 times, most recently
from
da739d0
to
a489adc
Compare
exo-swf
force-pushed
the
feature/experience
branch
2 times, most recently
from
b304469
to
61de30d
Compare
IlhemEssaadi
force-pushed
the
EXO-65477
branch
from
a489adc
to
63ecf7f
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
IlhemEssaadi
force-pushed
the
EXO-65477
branch
from
a41a4f1
to
f5ba0c0
Compare
azayati
requested changes
Sep 4, 2023
| import org.exoplatform.portal.mop.SiteKey; | ||
| import org.exoplatform.portal.mop.SiteType; | ||
| import org.exoplatform.portal.mop.navigation.Scope; | ||
| import org.exoplatform.portal.mop.service.LayoutService; | ||
| import org.exoplatform.portal.mop.user.*; |
There was a problem hiding this comment.
need to import explicitly the needed classes
| @@ -1688,4 +1706,92 @@ public static RelationshipManager getRelationshipManager() { | |||
| } | |||
| return relationshipManager; | |||
| } | |||
|
|
|||
| public static SiteRestEntity toSiteRestEntity(PortalConfig site, HttpServletRequest request, SiteFilter siteFilter) { | |||
There was a problem hiding this comment.
Suggested change
| public static SiteRestEntity toSiteRestEntity(PortalConfig site, HttpServletRequest request, SiteFilter siteFilter) { | |
| private static SiteRestEntity buildSiteEntity(PortalConfig site, HttpServletRequest request, SiteFilter siteFilter) { |
| rootNode == null ? null : toUserNodeRestEntity(rootNode.getChildren(), true, getOrganizationService(), getLayoutService(), getUserACL())); | ||
|
|
||
| } | ||
| public static List<SiteRestEntity> toSiteRestEntities(List<PortalConfig> sites, |
There was a problem hiding this comment.
Suggested change
| public static List<SiteRestEntity> toSiteRestEntities(List<PortalConfig> sites, | |
| public static List<SiteRestEntity> buildSiteEntities(List<PortalConfig> sites, |
| } | ||
| return new SiteRestEntity(siteType, | ||
| site.getName(), | ||
| !org.apache.commons.lang.StringUtils.isBlank(displayName) ? displayName : site.getName(), |
There was a problem hiding this comment.
add this import org.apache.commons.lang.StringUtils explicitly with the list of imports
| } | ||
| return layoutService; | ||
| } | ||
| public static boolean isDefaultSite(String siteName) { |
There was a problem hiding this comment.
Suggested change
| public static boolean isDefaultSite(String siteName) { | |
| private static boolean isDefaultSite(String siteName) { |
| @@ -0,0 +1,52 @@ | |||
| /* | |||
There was a problem hiding this comment.
Rename to SiteEntity instead of SiteRestEntity
IlhemEssaadi
force-pushed
the
EXO-65477
branch
3 times, most recently
from
42c2cb3
to
94bacc5
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
IlhemEssaadi
force-pushed
the
EXO-65477
branch
from
94bacc5
to
d60ed59
Compare
azayati
force-pushed
the
feature/experience
branch
from
61de30d
to
7ae1ec3
Compare
|
SonarCloud Quality Gate failed.
|
azayati
added a commit
that referenced
this pull request
Sep 4, 2023
azayati
added a commit
that referenced
this pull request
Sep 5, 2023
azayati
pushed a commit
that referenced
this pull request
Sep 6, 2023
azayati
added a commit
that referenced
this pull request
Sep 6, 2023
azayati
pushed a commit
that referenced
this pull request
Sep 6, 2023
azayati
added a commit
that referenced
this pull request
Sep 6, 2023
exo-swf
pushed a commit
that referenced
this pull request
Sep 6, 2023
exo-swf
pushed a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.