fix: Remove the user from the old group synchronized profile property groups - EXO-64814 - Meeds-io/meeds#1052 #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions list - EXO-64105 - Meeds-io/meeds#950 Prior to this change, when click on the three dots of a card user in a space member and check the display of the list options, this list must contain 6 options but the last option is hidden behind the card below To fix this problem, while clicking on the three dots we increase the z-index of this card. After this change, the list of options is displayed on the card below.
…erties including the first name or the last name - EXO-65382 - Meeds-io/meeds#1050 (#2697) Prior to this change, after updating multiple profile properties including the first name or the last name, the full name was not being updated. This issue occurred because the full name property was only updated when either the first name or the last name was changed. In the case of updating multiple properties at once, we need to fetch the newly updated profile to utilize the new value of the full name.
sofyenne
changed the title
…e - EXO-65724 - Meeds-io/meeds#1054 Prior to this change, when Open notification drawer and close a notification, The intended to be closed notification is opened instead. After this change, This notification is closed.
ahamdi
requested changes
Aug 7, 2023
| @@ -126,6 +127,7 @@ private void synchronizeProperty(Map.Entry<String, Object> property, Group profi | |||
| Group newPropertyNameGroup = getOrCreateGroup(propertyName, profileGroup); | |||
| try { | |||
| Group newPropertyValueGroup = getOrCreateGroup(propertyValue, newPropertyNameGroup); | |||
| removeUserFromExistingPropertyGroup(newPropertyNameGroup, user); | |||
There was a problem hiding this comment.
aren't you removing then adding the user to the same group here ?
There was a problem hiding this comment.
We are removing the user from the existing child group, and then adding them to the newly created child group within the same larger (parent) group!
fix: [Notifications] Notification drawer : close a notification issue - EXO-65724 - Meeds-io/meeds#1054
exo-swf
force-pushed
the
feature/maintenance
branch
from
da04fa6
to
15e33e9
Compare
ahamdi
approved these changes
Aug 8, 2023
|
Kudos, SonarCloud Quality Gate passed! |
exo-swf
pushed a commit
that referenced
this pull request
Aug 8, 2023
… groups - EXO-64814 - Meeds-io/meeds#1052 (#2702) Prior to this change, after editing a group-synchronized profile property, a new group was created, and the user continued to be displayed among the members of the old group This change is going to remove the user from the old group synchronized profile property groups.
sofyenne
added a commit
that referenced
this pull request
Aug 9, 2023
… groups - EXO-64814 - Meeds-io/meeds#1052 (#2702) Prior to this change, after editing a group-synchronized profile property, a new group was created, and the user continued to be displayed among the members of the old group This change is going to remove the user from the old group synchronized profile property groups.
sofyenne
added a commit
that referenced
this pull request
Aug 9, 2023
… groups - EXO-64814 - Meeds-io/meeds#1052 (#2702) Prior to this change, after editing a group-synchronized profile property, a new group was created, and the user continued to be displayed among the members of the old group This change is going to remove the user from the old group synchronized profile property groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, after editing a group-synchronized profile property, a new group was created, and the user continued to be displayed among the members of the old group
This change is going to remove the user from the old group synchronized profile property groups.