Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add activity/comment link for push notification - EXO-67587 - Meeds-io/meeds#1299 #55

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented Nov 20, 2023

Push notifications require that we put the notification link in the subject property to be used later as the link to redirect to when a user clicks on the received notification on their phones.
This fix makes sure that the link is added ion each notification otherwise, the curret server URL (Home) will be opened.

@ahamdi ahamdi self-assigned this Nov 20, 2023
Copy link

sonarcloud bot commented Nov 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

17.0% 17.0% Coverage
21.3% 21.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ahamdi ahamdi changed the title fix: add activity/comment link for push notification - EXO-67587 fix: add activity/comment link for push notification - EXO-67587 - Meeds-io/meeds#1299 Nov 20, 2023
@ahamdi ahamdi merged commit f63f6d4 into feature/maintenance Nov 20, 2023
8 of 9 checks passed
@ahamdi ahamdi deleted the fix/EXO-67587 branch November 20, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants