Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix SNV Editor Back Url - MEED-6937 - Meeds-io/meeds#2060 #80

Merged
merged 1 commit into from
May 28, 2024

Conversation

boubaker
Copy link
Member

Prior to this change, when editing SNV in full edit mode (with a new page opened in a new tab) and then the user publishes the SNV content, the SNV redirects to the previous page which is the Layout Editor. When the layout editor is opened again in a new Tab, a new draft page is opened and makes the first Tab with Layout editor in an invalid state. This change will avoid redirection to layout editor when publishing the SNV by introducing a global variable indicating the page being edited in editor and that should be used for redirection in SNV.

Prior to this change, when editing SNV in full edit mode (with a new page opened in a new tab) and then the user publishes the SNV content, the SNV redirects to the previous page which is the Layout Editor. When the layout editor is opened again in a new Tab, a new draft page is opened and makes the first Tab with Layout editor in an invalid state. This change will avoid redirection to layout editor when publishing the SNV by introducing a global variable indicating the page being edited in editor and that should be used for redirection in SNV.
@boubaker boubaker merged commit 601425c into feature/whitepaper May 28, 2024
1 check passed
@boubaker boubaker deleted the meed-6937 branch May 28, 2024 11:25
boubaker added a commit that referenced this pull request May 28, 2024
Prior to this change, when editing SNV in full edit mode (with a new
page opened in a new tab) and then the user publishes the SNV content,
the SNV redirects to the previous page which is the Layout Editor. When
the layout editor is opened again in a new Tab, a new draft page is
opened and makes the first Tab with Layout editor in an invalid state.
This change will avoid redirection to layout editor when publishing the
SNV by introducing a global variable indicating the page being edited in
editor and that should be used for redirection in SNV.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant