fix: add supported MotherDuck connection string parameters #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MotherDuck supports motherduck_token, attach_mode and saas_mode in the connection string. See: https://motherduck.com/docs/key-tasks/authenticating-and-connecting-to-motherduck/authenticating-to-motherduck/#using-connection-string-parameters
FinnWoelm
force-pushed
the
add-motherduck-connection-string-params
branch
from
f1645f8 to
c57f024
Compare
|
Force-pushed to fix commit message format |
Mause
changed the title
|
Looks great, thanks! |
|
Released in https://github.com/Mause/duckdb_engine/releases/tag/v0.15.0 :D |
|
Wow, that was fast! Thanks so much 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Mause,
Thanks so much for creating the SQLAlchemy driver for DuckDB 🙌
We're going to use the driver to connect to MotherDuck, so we would like to have support for the
attach_modeandsaas_modeconnection string parameters. They are useful for our production-level applications where we need to restrict the privileges of the MotherDuck connection.See for details:
https://motherduck.com/docs/key-tasks/authenticating-and-connecting-to-motherduck/authenticating-to-motherduck/#using-connection-string-parameters
Do you think it would be possible to merge these in? Let me know if I can do anything else to support.
- Finn