Merge pull request #280 from Mause/bugfix/correct-dialect-registration

fix: use modern dialect registration
Mause · Jun 23, 2022 · dbcc237 · dbcc237
2 parents 6273aa1 + 6790536
commit dbcc237
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/duckdb_engine/__init__.py b/duckdb_engine/__init__.py
@@ -7,8 +7,6 @@
 from sqlalchemy.dialects.postgresql.base import PGExecutionContext, PGInspector
 from sqlalchemy.engine.url import URL
 
-name = "duckdb"  # TODO: find if sqlalchemy documents this field anywhere
-
 
 class DBAPI:
     paramstyle = "qmark"
@@ -196,6 +194,3 @@ def get_view_names(
         rs = connection.exec_driver_sql(s)
 
         return [row[0] for row in rs]
-
-
-dialect = Dialect
diff --git a/pyproject.toml b/pyproject.toml
@@ -27,7 +27,7 @@ ipython-sql = "^0.4.1"
 sqlalchemy-stubs = "^0.4"
 
 [tool.poetry.plugins."sqlalchemy.dialects"]
-duckdb = "duckdb_engine"
+duckdb = "duckdb_engine:Dialect"
 
 [tool.pytest.ini_options]
 addopts = "--hypothesis-show-statistics"