Event buffers #53
Merged
Event buffers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the 'stream' and 'iterable' methods to be shared and usable by both Session and EventBuffer and to each use their respective 'push' methods to create new events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
Sessionbuffer functionality into a newEventBufferclass.This gives us the ability to add event batching (#42) now that we can create multiple event buffers that can be used by a single session.
In addition, it is exposed publicly so that users who just want to write a raw text stream of spec-compliant SSE fields can do so easily without the need to instantiate a
Session. This an advanced use-case, however, and the vast majority of users should still stick withSessionand its much simpler helper methods.Naturally, this also deprecates the buffer-related methods on
Sessionas they are now redundant. See #52.