Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for node 10 #6

Merged
merged 3 commits into from
Apr 12, 2019
Merged

Add support for node 10 #6

merged 3 commits into from
Apr 12, 2019

Conversation

glibas
Copy link
Collaborator

@glibas glibas commented Apr 12, 2019

Add node 10 to appveyor build matrix

@glibas
Copy link
Collaborator Author

glibas commented Apr 12, 2019

@MatthD , @trollkotze , could you please take a look and merge this one. Appveyor build passing.

Thanks in advance.

@glibas
Copy link
Collaborator Author

glibas commented Apr 12, 2019

Fixes #3

@glibas
Copy link
Collaborator Author

glibas commented Apr 12, 2019

Hi @MatthD , @trollkotze it looks like you are not actively supporting this project any more. Would you be able to merge the PR or add me as contributor? really need v 10 support.

@MatthD
Copy link
Owner

MatthD commented Apr 12, 2019

Hi @glib-briia thank you very much for this PR , I will add you as contributor to be able to maintain it too.

@MatthD MatthD merged commit f19fafb into MatthD:master Apr 12, 2019
@MatthD
Copy link
Owner

MatthD commented Apr 15, 2019

It's ok for me @glib-briia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants