Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for isue #29 #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for isue #29 #31

wants to merge 1 commit into from

Conversation

gfouquet
Copy link

@gfouquet gfouquet commented Nov 6, 2013

Hi,

This pull request enables user to specify if he wants to use Rhino or Node. As a result, when node is installed, user is still able to use rhino.

@gfouquet
[Issue MattCheely#29] Added an optional "runner" parameter with which…
d2a54cd 
… one can specify if he wants to use rhino or node. It defaults to nodejs
@bringking
Copy link

@gfouquet, if you would like to submit this PR to my fork here, I will get it into the next release and out on the central repo.

@gfouquet
Copy link
Author

gfouquet commented Jan 6, 2014

@bringking Thank you, I just submitted a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfouquet @bringking