replace test on valid size with an assert

CreateElementUsingContext() never creates an element with an invalid size.
Matroska-Org · Feb 25, 2024 · 95e7d8d · 95e7d8d
1 parent 89dab92
commit 95e7d8d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/EbmlElement.cpp b/src/EbmlElement.cpp
@@ -324,6 +324,7 @@ EbmlElement * EbmlElement::FindNextElement(IOCallback & DataStream, const EbmlSe
       ///< \todo continue is misplaced
       if (Result != nullptr) {
         if (AllowDummyElt || !Result->IsDummy()) {
+          assert(Result->ElementSpec().IsSizeValid(SizeFound));
           Result->SetSizeLength(_SizeLength);
 
           Result->Size = SizeFound;
@@ -332,7 +333,7 @@ EbmlElement * EbmlElement::FindNextElement(IOCallback & DataStream, const EbmlSe
           //  0 : child
           //  1 : same level
           //  + : further parent
-          if (Result->ElementSpec().IsSizeValid(SizeFound) && (SizeFound == SizeUnknown || UpperLevel > 0 || MaxDataSize == 0 ||
+          if ((SizeFound == SizeUnknown || UpperLevel > 0 || MaxDataSize == 0 ||
                                          MaxDataSize >= (IdStart + PossibleID_Length + _SizeLength + SizeFound))) {
             Result->ElementPosition = ParseStart + IdStart;
             Result->SizePosition = Result->ElementPosition + PossibleID_Length;