Update env checker

MathieuSoysal · Apr 24, 2023 · 37d8d2b · 37d8d2b
1 parent 0b39811
commit 37d8d2b
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 7 deletions.
diff --git a/src/main/java/io/github/mathieusoysal/App.java b/src/main/java/io/github/mathieusoysal/App.java
@@ -1,23 +1,22 @@
 package io.github.mathieusoysal;
 
+import java.util.ArrayList;
+
 import com.github.forax.beautifullogger.Logger;
 
 import io.github.mathieusoysal.exceptions.EnvironementVariableNotFoundException;
 import io.github.mathieusoysal.exceptions.RobotoException;
 
 public class App {
 
+    private static final String ENV_NAME_PASSWORD = "TEST_PASSWORD";
+    private static final String ENV_NAME_MAIL = "TEST_EMAIL";
     private static final Logger LOGGER = Logger.getLogger();
 
     public static void main(String[] args) {
-        try {
-            checkEnvVariable("TEST_EMAIL");
-            checkEnvVariable("TEST_PASSWORD");
-        } catch (EnvironementVariableNotFoundException e) {
-            LOGGER.error(e.getMessage(), e);
-        }
+        checkAllEnvVariables(ENV_NAME_MAIL, ENV_NAME_PASSWORD);
         try (Roboto roboto = new Roboto()) {
-            roboto.connect(System.getenv("TEST_EMAIL"), System.getenv("TEST_PASSWORD"));
+            roboto.connect(System.getenv(ENV_NAME_MAIL), System.getenv(ENV_NAME_PASSWORD));
             while (!roboto.checkinButtonIsPresent())
                 roboto.refreshPage();
             roboto.clickOnSubscription();
@@ -26,6 +25,22 @@ public static void main(String[] args) {
         }
     }
 
+    static void checkAllEnvVariables(String... envNames) {
+        var notFound = new ArrayList<String>();
+        for (String name : envNames) {
+            try {
+                checkEnvVariable(name);
+            } catch (EnvironementVariableNotFoundException e) {
+                LOGGER.error(e.getMessage(), e);
+                notFound.add(name);
+            }
+        }
+        if (notFound.size() > 0) {
+            throw new RuntimeException(
+                    "Please set the following environment variables: " + String.join(", ", notFound));
+        }
+    }
+
     static void checkEnvVariable(String name) throws EnvironementVariableNotFoundException {
         if (System.getenv(name) == null) {
             throw new EnvironementVariableNotFoundException(name);

diff --git a/src/test/java/io/github/mathieusoysal/AppTest.java b/src/test/java/io/github/mathieusoysal/AppTest.java
@@ -28,4 +28,11 @@ void testCheckEnvVariable2() {
         });
     }
 
+    @Test
+    void testCheckAllEnvVariables() {
+        assertDoesNotThrow(() -> {
+            App.checkAllEnvVariables();
+        });
+    }
+
 }