Split out no-meaning operators into separate builtin modules; add correct precedence for no-meaning infix operators #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Operators without Built-in Meanings is now a "Guide section" with parts for postfix, prefix and infix operators and operators that require additional Mathics3 module loading. The precedence for infix operators is not set properly.
|
After this is merge, there will be yet one more round that has to take place on both the MathicsScanner side and mathics-core side to redo table generation to include operator precedence for prefix and postfix no-meaning operators. |
Note: class creation code has to be in the respective modules for `type()` to put the newly created class in the proper module. This leads to a little bit of duplication of code, but on the other hand, it makes some tricky code easier to follow
rocky
force-pushed
the
no-meaning-part2
branch
from
c27613c to
8a34c3c
Compare
|
After this merge, Mathics3 module graph needs to be revised to import DirectedEdge and UndirectedEdge from changed module locations. |
rocky
changed the title
|
Great - then onto the next steps (a little later on). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operators without Built-in Meanings is now a "Guide section" with parts for postfix, prefix, and infix operators and operators that require additional Mathics3 module loading.
The precedence for infix operators is now set properly.