-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added KNN #16
Added KNN #16
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ramyashreeshetty Thank you for the PR. But looks like you have used sklearn and imported KNeighborsClassifier. But instead, you have to implement it from scratch.
@HemanthSai7 i understand, i'll implement kneighborsclassifier from scratch. |
@HemanthSai7 hey i have updated it! could u review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramyashreeshetty Looks gr8!🔥. Could you please document your code. Have a look at the logistic regression notebook.
Thanks.
@HemanthSai7 i have added it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🔥
fixes #9
Description
KNN
Type of change
Note: Please delete options that are not relevant.
Implementation details
(only for
New layer/algorithm
)Checklist