Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added KNN #16

Merged
merged 14 commits into from
Oct 8, 2022
Merged

Added KNN #16

merged 14 commits into from
Oct 8, 2022

Conversation

ramyashreeshetty
Copy link
Contributor

fixes #9

Description

KNN

Type of change

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New layer/algorithm
  • Other (Specify)

Implementation details

(only for New layer/algorithm)

  • List all the packages and their versions used:
    numpy==1.21.5
    pandas==1.4.2
    sklearn==1.0.2
  • Include test results such as:
    Accuracy score:0.93
    Precision score: 0.8787878787878788
    Recall score: 0.90625

Checklist

  • I have performed a self code_review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@HemanthSai7 HemanthSai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ramyashreeshetty Thank you for the PR. But looks like you have used sklearn and imported KNeighborsClassifier. But instead, you have to implement it from scratch.

@ramyashreeshetty
Copy link
Contributor Author

@HemanthSai7 i understand, i'll implement kneighborsclassifier from scratch.

@ramyashreeshetty
Copy link
Contributor Author

@HemanthSai7 hey i have updated it! could u review it

Copy link
Member

@HemanthSai7 HemanthSai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramyashreeshetty Looks gr8!🔥. Could you please document your code. Have a look at the logistic regression notebook.
Thanks.

@ramyashreeshetty
Copy link
Contributor Author

@HemanthSai7 i have added it.

Copy link
Member

@HemanthSai7 HemanthSai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🔥

@HemanthSai7 HemanthSai7 merged commit be16d35 into Math-behind-AI:main Oct 8, 2022
@HemanthSai7 HemanthSai7 added new layer/algo New layer/algorithm with implementation from scratch hacktoberfest-accepted hacktoberfest hacktoberfest label for contributors labels Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest hacktoberfest label for contributors hacktoberfest-accepted new layer/algo New layer/algorithm with implementation from scratch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new ML Algorithms
2 participants