homework #262
Open
homework #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 26, 2022 17:46
DrSmile444
requested changes
Jan 11, 2023
| @@ -0,0 +1,14 @@ | |||
| function height(tree) { | |||
There was a problem hiding this comment.
- The function name should have a verb. For example,
updateUser,fetchEntity,findLowestNumber,showTicket,displayName.
height is a bad name for a function, because it doesn't describe what the function does and there is no verb in the name. Please, find a new one.
treeis also not a valid name for the tree height argument. It would be sound better if you name itheight
DrSmile444
requested changes
Jan 11, 2023
| [8, 6, 8, 6, 6, 7, 7, 6, 6, 7, 8, 7, 6, 6, 6, 6, 7, 8, 7], | ||
| ]; | ||
|
|
||
| const arr = array.map((ofArray) => ofArray.map((of) => (of > 4 ? '$' : '*')).join('')); |
There was a problem hiding this comment.
-
arris a bad name for the changed array. Could you let me know what you did here? You have remapped the array to have a new array. So let's rename it to aresultArray; -
ofArrayis a bad name for an array row. By the way,rowwill sound better ;) -
of? What does it mean? If we image this array as a table, we haverows,columns, andcells. So the best name for it would becell. Please, rename it
added 2 commits
January 12, 2023 13:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.