-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0 intro david tereshchenko #9
Conversation
package-lock.json
Outdated
@@ -1,8 +1,12479 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @DavidTereshchenko, please remove this file from your pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shoud remove this changes, not existing file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooops, i fixed it
package-lock.json
Outdated
@@ -1,8 +1,12479 @@ | |||
{ | |||
"name": "fe-course-basic-2023", | |||
"version": "21.0.0", | |||
"lockfileVersion": 1, | |||
"lockfileVersion": 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should have a value of 1? this value was after "npm install"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this task you should only add your Readme, not change the settings of whole repo.
So yes, if you change 2 to 1 back, it returns the file to initial state and remove its changes from your pull-request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the most interesting thing is that I didn't touch that file, I don't even know why there are changes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did i do my homework ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there, sorry, but not. You still have some changes for the project's package-lock.json. If I merge your pr, these changes will rewrite it. And that is not, what you have to do in this task.
I've wrote a way to deal with this problem and its explanation in tg chat - https://t.me/c/1602765599/177.
Or you could ask Bard/ChatGPT what's going on and how to solve it
homework #9 - Async & Fetch.
No description provided.