Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 hall of fame page layout bogdandrummer #476

Conversation

Bogdandrummer
Copy link
Collaborator

No description provided.

@AndriiMorozov88
Copy link
Collaborator

Картки вистроюються в одну колонку при ширині екрана 640px, стрілка вгору з'являється при ширині екрана 599 рх... якось нелогічно.

const arrowAppearance = () => {
if (window.innerWidth < 602 || window.innerWidth > 602) {
checkScroll();
}
};
не зовсім розумію умову в функції... по суті тут виключене тільки число 602 при якому запускається функція

docs/index.html Outdated Show resolved Hide resolved
docs/src/styles/style.css Show resolved Hide resolved
Copy link
Collaborator

@IgorFromUA IgorFromUA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. It seems to me that it is necessary to remove the "font-family" from all classes except class ".body".

docs/src/styles/style.css Show resolved Hide resolved
docs/src/styles/style.css Show resolved Hide resolved
Copy link
Collaborator

@vladyslav-yermolin-moc vladyslav-yermolin-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Bogdandrummer, I've resolved the conflict in index.html for you

@vladyslav-yermolin-moc vladyslav-yermolin-moc merged commit 444ba39 into 11-hall_of_fame Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants