Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unnecessary template tags #473

Merged
merged 2 commits into from
Mar 19, 2024
Merged

removed unnecessary template tags #473

merged 2 commits into from
Mar 19, 2024

Conversation

NosatskyiK
Copy link
Collaborator

removed unnecessary social network icons and reduced the code

IgorFromUA
IgorFromUA approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@IgorFromUA IgorFromUA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, if you don't need the data attribute for social media templates, then everything is fine.

@vladyslav-yermolin-moc vladyslav-yermolin-moc merged commit 93b70f7 into 11-hall_of_fame Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgorFromUA IgorFromUA IgorFromUA approved these changes

@vladyslav-yermolin-moc vladyslav-yermolin-moc vladyslav-yermolin-moc approved these changes

@AndriiMorozov88 AndriiMorozov88 Awaiting requested review from AndriiMorozov88

@Bogdandrummer Bogdandrummer Awaiting requested review from Bogdandrummer

Assignees

@vladyslav-yermolin-moc vladyslav-yermolin-moc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NosatskyiK @vladyslav-yermolin-moc @IgorFromUA