HW-10: final #456
Merged
HW-10: final #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rogerosha thank you for the good job! |
anna-vrana-moc
requested changes
Jan 8, 2024
anna-vrana-moc
added
the
Ready to final review
|
Hey, teams @MZabolotnev @oleg-nikulin-moc @vladyslav-yermolin-moc @vadym-zinchenko-moc ! I have one small suggestion about footer, so I believe you can take look as well |
vladyslav-yermolin-moc
requested changes
Jan 8, 2024
homeworks/kostiantyn.nosatskyi_NosatskyiK/4-js_basics/basics.js
Outdated
Show resolved
Hide resolved
|
Hey, @anna-vrana-moc, I'm afraid, the deadline for mentors deep review was yesterday. So I will merge this pr, after small change described in my comment. |
# Conflicts: # docs/index.html
vladyslav-yermolin-moc
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! My project living on this site: https://rogerosha.github.io/fe-course-basic-2023/
I made it adaptive for phones and tablets, hope everything works well!
Thank you for everything you did! It's an incredible experience🌷