Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10_final_SviatoslavTaranenko #442

Merged
merged 37 commits into from
Jan 8, 2024

Conversation

SviatoslavTaranenko
Copy link
Collaborator

Link to deployed project - https://sviatoslavtaranenko.github.io/fe-course-basic-2023/
Without filters

Copy link
Contributor

@MZabolotnev MZabolotnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привіт! гарна робота. Є пару зауважень:
image
Різні відступи
image
Зроби будь ласка відступи однаковими

MZabolotnev
MZabolotnev previously approved these changes Dec 28, 2023
@MZabolotnev MZabolotnev added the Ready to final review The pr is ready for review of random mentor label Dec 28, 2023
docs/index.html Outdated Show resolved Hide resolved
docs/SviatoslavTaranenko/Styles/style.css Show resolved Hide resolved
docs/SviatoslavTaranenko/Styles/style.css Show resolved Hide resolved
docs/SviatoslavTaranenko/Styles/style.css Show resolved Hide resolved
docs/SviatoslavTaranenko/Styles/style.css Show resolved Hide resolved
docs/SviatoslavTaranenko/Games.html Outdated Show resolved Hide resolved
docs/SviatoslavTaranenko/Games.html Outdated Show resolved Hide resolved
docs/SviatoslavTaranenko/scripts/Games.js Outdated Show resolved Hide resolved
docs/SviatoslavTaranenko/scripts/Games.js Show resolved Hide resolved
docs/SviatoslavTaranenko/Games.html Show resolved Hide resolved
@vladyslav-yermolin-moc
Copy link
Collaborator

Thanks for a good work 😎

Copy link
Collaborator

@vladyslav-yermolin-moc vladyslav-yermolin-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably, I didn't update your repo, cause here I still see an old version of your project https://sviatoslavtaranenko.github.io/fe-course-basic-2023/

docs/SviatoslavTaranenko/index.html Outdated Show resolved Hide resolved
docs/SviatoslavTaranenko/scripts/Games.js Outdated Show resolved Hide resolved
docs/SviatoslavTaranenko/scripts/Games.js Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@vladyslav-yermolin-moc vladyslav-yermolin-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, OK, I've made the changes for you.
Thanks for your efforts, @SviatoslavTaranenko

@vladyslav-yermolin-moc vladyslav-yermolin-moc merged commit 22cf541 into main Jan 8, 2024
4 checks passed
@SviatoslavTaranenko
Copy link
Collaborator Author

@vladyslav-yermolin-moc thanks for understanding and for your help))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final reviewer assigned Ready to final review The pr is ready for review of random mentor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants