Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 final lesiaturuta #432

Merged
merged 13 commits into from
Jan 12, 2024

Conversation

lesiaturuta
Copy link
Collaborator

@lesiaturuta lesiaturuta commented Dec 17, 2023

Update I've added a link to your stage https://lesiaturuta.github.io/fe-course-basic-2023/

@vladyslav-yermolin-moc vladyslav-yermolin-moc added Ready to final review The pr is ready for review of random mentor and removed Ready to final review The pr is ready for review of random mentor labels Dec 19, 2023
docs/lesiaturuta/5-logic/homework.js Outdated Show resolved Hide resolved
docs/lesiaturuta/5-logic/homework.js Outdated Show resolved Hide resolved
docs/lesiaturuta/5-logic/index.html Outdated Show resolved Hide resolved
docs/lesiaturuta/PokemonProject/scripts/pokemon.js Outdated Show resolved Hide resolved
docs/lesiaturuta/PokemonProject/scripts/checkScroll.js Outdated Show resolved Hide resolved
docs/lesiaturuta/PokemonProject/loader/loader.css Outdated Show resolved Hide resolved
docs/lesiaturuta/PokemonProject/style.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@vladyslav-yermolin-moc vladyslav-yermolin-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @lesiaturuta, thanx for your good work! I'm gonna approve it for final review, you can fix the remaining comments in the process.
Don't forget to resolve conflicts in the top index.html file before the final merge.
image

@anna-vrana-moc
Copy link
Collaborator

Hi @lesiaturuta! I'll check your project step by step

@anna-vrana-moc
Copy link
Collaborator

  1. please add some paddings to the main block of the Login page
Screenshot 2024-01-05 at 01 05 29 You can use the mockup as an example Screenshot 2024-01-05 at 01 07 55

@anna-vrana-moc
Copy link
Collaborator

It's just a piece of advice: try to avoid consolidating all styles into one file. Instead, it's better to create separate files for each page. This approach helps in navigating styles more effectively, preventing the addition of redundant styles across all pages. If you have one file with all styles, it can become excessively large and negatively impact page speed

@anna-vrana-moc
Copy link
Collaborator

  1. You can resize font-sizes of the text and gaps to improve the mobile view:
    Your current mobile view
Screenshot 2024-01-05 at 01 16 04 Just example from me Screenshot 2024-01-05 at 01 57 16

docs/lesiaturuta/PokemonProject/style.css Outdated Show resolved Hide resolved
docs/lesiaturuta/PokemonProject/style.css Show resolved Hide resolved
docs/lesiaturuta/PokemonProject/style.css Outdated Show resolved Hide resolved
@anna-vrana-moc
Copy link
Collaborator

Please be attentive to the fixed heights present in the style.css file. Kindly review the entire file and fix any instances where fixed heights are specified. It's recommended to ensure flexibility in height to accommodate varying content and screen sizes. Thank you!

@vladyslav-yermolin-moc vladyslav-yermolin-moc removed their assignment Jan 8, 2024
@anna-vrana-moc anna-vrana-moc merged commit 8ac6f18 into MastersAcademy:main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final reviewer assigned Ready to final review The pr is ready for review of random mentor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants