-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10 final lesiaturuta #432
10 final lesiaturuta #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @lesiaturuta, thanx for your good work! I'm gonna approve it for final review, you can fix the remaining comments in the process.
Don't forget to resolve conflicts in the top index.html
file before the final merge.
Hi @lesiaturuta! I'll check your project step by step |
It's just a piece of advice: try to avoid consolidating all styles into one file. Instead, it's better to create separate files for each page. This approach helps in navigating styles more effectively, preventing the addition of redundant styles across all pages. If you have one file with all styles, it can become excessively large and negatively impact page speed |
Please be attentive to the fixed heights present in the |
Update I've added a link to your stage https://lesiaturuta.github.io/fe-course-basic-2023/