Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10 final demasha0908 #430

Merged
merged 5 commits into from
Jan 8, 2024
Merged

10 final demasha0908 #430

merged 5 commits into from
Jan 8, 2024

Conversation

demasha0908
Copy link
Collaborator

oleg-nikulin-moc
oleg-nikulin-moc reviewed Dec 21, 2023
View reviewed changes
docs/demasha0908/css/style.css Outdated
display: flex;
justify-content: space-between;
gap: 65px;
margin-top: 60px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Намагайся не використовувати margin-top бо в майбутньому може зустрічати таке явище як margin collapsing ,можеш почитати що це таке https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_box_model/Mastering_margin_collapsing.

oleg-nikulin-moc
oleg-nikulin-moc requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@oleg-nikulin-moc oleg-nikulin-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вибач, що довго не перевіряв, на мобайлі тут є проблема https://tppr.me/6hJrcg, такст злипся, потрібно додати line-height. також за великі падінгі ідля карток на мобайлі можна зробити ширину на 100% до певної ширини єкрану, щоб було гарно і якісь падінги для контейнера. Також сама картка не симетрично виглядає. На Ipad також трохи поїхало, походу щось кудись не влазить. https://tppr.me/3ZVJR2

@oleg-nikulin-moc
Copy link
Collaborator

Db не забудь пройтися по чеклісту

@MZabolotnev MZabolotnev self-requested a review January 5, 2024 17:16
@MZabolotnev MZabolotnev self-assigned this Jan 5, 2024
MZabolotnev
MZabolotnev previously approved these changes Jan 5, 2024
View reviewed changes
@MZabolotnev MZabolotnev added Ready to final review The pr is ready for review of random mentor Final reviewer assigned labels Jan 5, 2024
@vladyslav-yermolin-moc
Copy link
Collaborator

I've resolved the conflict in the index.html and gonna merge this pr

@vladyslav-yermolin-moc vladyslav-yermolin-moc merged commit 9303a80 into main Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MZabolotnev MZabolotnev MZabolotnev left review comments

@oleg-nikulin-moc oleg-nikulin-moc Awaiting requested review from oleg-nikulin-moc

Assignees

@MZabolotnev MZabolotnev

@oleg-nikulin-moc oleg-nikulin-moc

Labels
Final reviewer assigned Ready to final review The pr is ready for review of random mentor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@demasha0908 @oleg-nikulin-moc @vladyslav-yermolin-moc @MZabolotnev