-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10-final_Allocene #424
10-final_Allocene #424
Conversation
Hey, @Allocene, please add a link to your deloyed project, as other students do #434 (comment) |
I deployed my project through a third-party resource. Here is a link to the project - Artur Kobyliatsky (click to open) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change files only in the docs
folder.
Try to remove changes of files in folder homeworks/artur...
from this pull request
homeworks/artur.kobyliatsky_Allocene/GamesProject/style/main-calculator.css
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a strange feeling: seems like you want to compete with me or other mentors and try to avoid fixing your code on our comments.
This is not a competition. We like to teach you something useful, based on our experience.
If you don't like our comments, I can merge your request "as is" and save my and your time, not a problem🤷♂️
P.S.: please do not resolve my comments, anyway I should open them and check your fixes. Better add fixed
comment
I'm sorry that it seems that way, because in reality it's not like that, it's simple and I never understand why and I'm waiting for some logical explanations, but I gladly make all the corrections, because I understand that this is experience, and this is exactly the small work that you talked about last time |
Hey, @Allocene, thanks for your fixes. I don't clearly understand, what you mean by
These two rules are best practices in HTML+CSS+JS(pure) projects Is this explanation what you were waiting for? Anyway, would be good for such cases to ask a question in comments on GitHub or in tg, rather than silently ignore or resolve the mentor's comment. |
No description provided.