Upgrade v9.19.17 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 'main' Attach to the dns_dispatchmgr in the dns_view object Closes #4228 See merge request isc-projects/bind9!8203
The following files were reported in CI by the legacy system test runner
and prevented job to pass. They should be removed.
$ if git rev-parse > /dev/null 2>&1; then ( ! grep "^I:.*:file.*not removed$" *.log ); fi
autosign.log:I:autosign:file autosign/ns3/kskonly.example.db.jbk not removed
autosign.log:I:autosign:file autosign/ns3/optout.example.db.jbk not removed
autosign.log:I:autosign:file autosign/ns3/reconf.example.db.jbk not removed
masterformat.log:I:masterformat:file masterformat/ns1/signed.db.raw.jbk not removed
masterformat.log:I:masterformat:file masterformat/ns1/signed.db.raw.signed not removed
masterformat.log:I:masterformat:file masterformat/ns1/signed.db.raw.signed.jnl not removed
Don't print an error when the ns*/inactive directory is not
present:
rmdir: ns*/inactive: No such file or directory
Remove nsupdate.out.test file instead of nsupdate.out, as the latter
does not exist.
Clean leftover files in autosign and masterformat See merge request isc-projects/bind9!8167
If the flaky plugin for pytest is available, use its decorator to support re-running unstable tests. In case the package is missing, execute the test as usual without attempts to re-run it in case of failure. This is mostly intended to increase the test stability in CI. Using a custom decorator enables us to keep the flaky package as an optional dependency.
In some cases, BIND is not fast enough to fill the send buffer and manages to answer all queries, contrary to what the test expects. Repeat the check up to 3 times to limit this test instability.
Make the test_send_timeout check more stable Closes #4139 See merge request isc-projects/bind9!8168
This reverts commit 4eac32f. With the v9.19.16 release tag merged, the "cross-version-config-tests" GitLab CI job will no longer fail due to the two relevant system tests being absent from the development branch. This makes the pytest filtering expression added to work around that issue unnecessary, so remove it.
Update the release checklist with links to recently implemented tools for automating certain tasks.
Post-release tweaks (cross-version testing cleanup, release checklist tweaks) See merge request isc-projects/bind9!8210
A negative or excessively large Content-Length could cause a crash by making `INSIST(httpd->consume != 0)` fail.
Parse statschannel Content-Length: more carefully Closes #4125 See merge request isc-projects/bind9!8018
A supported pytest version finally made it to OpenBSD repositories, allowing us to run system tests with the pytest runner.
Out-of-tree builds are built in a directory that is different from source directory. The build directory doesn't contain the non-compiled test files from bin/tests/system which are the test cases required by the pytest runner. In order to run the system tests for out-of-tree build, copy over the contents (tests) of bin/tests/system/ from the source directory into the build directory. Then, it is possible to invoke the pytest runner inside the build directory.
Use pytest runner for out-of-tree and OpenBSD system tests in CI Closes #4246 See merge request isc-projects/bind9!8193
Add release note for [GL #4125] Closes #4125 See merge request isc-projects/bind9!8216
While temporary directories are useful for test execution to keep everything clean, they are difficult to work with manually. Create a symlink for each test artifact directory with a stable and predictable path. The symlink always either points to the latest artifacts, or is missing in case the last run succeeded. Ensure these symlinked directories aren't detected as test suites by the pytest runner.
At the end of the test, display the symlink path to the artifact directory in case it's preserved. Log the full tempdir name in debug log.
While it'd be fairly easy to split the function up into smaller ones, the readability wouldn't be improved in this case. Silence the suggestions instead.
The command finds all directories in bin/tests/system which contain an underscore. Underscore indicates either a temporary directory (_tmp_), a symlink to test artifacts (TESTNAME_MODULENAME), or a python-related cache. Using underscore for a system test name is invalid and a hyphen must be used instead.
Create symlinks to test artifacts for pytest runner Closes #4252 See merge request isc-projects/bind9!8194
Instead of growing and never shrinking the list of the inactive handles (to be reused mostly on the UDP connections), limit the number of maximum number of inactive handles kept to 64. Instead of caching the inactive handles for all listening sockets, enable the caching on on UDP listening sockets. For TCP, the handles were cached for each accepted socket thus reusing the handles only for long-standing TCP connections, but not reusing the handles across different TCP streams.
Set the number of maximum free items for the uvreq memory pool to 64.
…'main' Limit the number of inactive handles and uvreqs kept for reuse Closes #4265 See merge request isc-projects/bind9!8206
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades OQS-bind to bind version v9.19.17.