Skip to content

Commit

Permalink
fix: do not mount input dir on remote (#201)
Browse files Browse the repository at this point in the history
Auto-created
  • Loading branch information
MartinBernstorff authored Nov 18, 2023
1 parent b734f9e commit 83cedae
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"mounts": [
"source=${localEnv:HOME}/.config/gh/hosts.yml,target=/root/.config/gh/hosts.yml,type=bind,consistency=cache", // GitHub CLI authentication login
"source=${localEnv:HOME}/ankidecks,target=/output/,type=bind,consistency=cache",
"source=/Users/Shared/life-lessons/docs/life-lessons/,target=/input/,type=bind,consistency=cache",
// "source=/Users/Shared/life-lessons/docs/life-lessons/,target=/input/,type=bind,consistency=cache",
],
"features": {
"ghcr.io/devcontainers/features/github-cli:1": {}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ jobs:
run: | # If this file is not created, the dev container fails because of non-existant mount
mkdir -p ~/.config/gh
mkdir -p ~/ankidecks
mkdir -p /Users/Shared/life-lessons/docs/life-lessons/
touch ~/.config/gh/hosts.yml
- name: Pre-build dev container image
Expand Down
13 changes: 6 additions & 7 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ validate: ## Run all checks
make lint
make type-check
make test
make build

merge-main:
git fetch
Expand Down Expand Up @@ -54,13 +53,13 @@ pr-status:
@gh pr view | cat | grep "url"

pr: ## Run relevant tests before PR
make push
make create-pr
make merge-main
make validate
make enable-automerge
@make push
@make create-pr
@make merge-main
@make validate
@make enable-automerge
@echo "––– 🎉🎉🎉 All tests succeeded! 🎉🎉🎉 –––"
make pr-status
@make pr-status

grow:
make pr
Expand Down

0 comments on commit 83cedae

Please sign in to comment.