dev: makefile success messages (#221)

Auto-created
MartinBernstorff · Nov 19, 2023 · 3e3e4e1 · 3e3e4e1
1 parent 0344b3c
commit 3e3e4e1
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -9,13 +9,15 @@
             "command": "make pr-status",
             "group": "test",
             "dependsOn": [
+                "Setup PR",
                 "Lint",
                 "Test",
                 "Static type check",
-                "Setup PR",
             ],
             "presentation": {
                 "reveal": "always",
+                "clear": true,
+                "showReuseMessage": false,
                 "group": "pr"
             }
         },
@@ -25,6 +27,8 @@
             "command": "make lint",
             "presentation": {
                 "reveal": "always",
+                "clear": true,
+                "showReuseMessage": false,
                 "group": "pr"
             },
             "problemMatcher": []
@@ -35,6 +39,8 @@
             "command": "make setup-pr",
             "presentation": {
                 "reveal": "always",
+                "clear": true,
+                "showReuseMessage": false,
                 "group": "pr"
             },
             "problemMatcher": []
@@ -45,6 +51,8 @@
             "command": "make test",
             "presentation": {
                 "reveal": "always",
+                "clear": true,
+                "showReuseMessage": false,
                 "group": "pr"
             },
         },
@@ -54,6 +62,8 @@
             "command": "make types",
             "presentation": {
                 "reveal": "always",
+                "clear": true,
+                "showReuseMessage": false,
                 "group": "pr"
             }
         }

diff --git a/makefile b/makefile
@@ -21,6 +21,7 @@ install:
 test: ## Run tests
 	@echo "––– Testing –––"
 	@pytest personal_mnemonic_medium
+	@echo "✅✅✅ Tests passed ✅✅✅"
 
 test-cov: ## Run tests with coverage
 	# TODO: https://github.com/MartinBernstorff/personal-mnemonic-medium/issues/209 Fix coverage and add it to make pr
@@ -32,10 +33,12 @@ lint: ## Format code
 	@ruff . --fix \
 		--extend-select F401 \
 		--extend-select F841
+	@echo "✅✅✅ Lint ✅✅✅"
 
 types: ## Type-check code
 	@echo "––– Type-checking –––"
 	@pyright $(SRC_PATH)
+	@echo "✅✅✅ Types ✅✅✅"
 
 validate: ## Run all checks
 	@echo "––– Running all checks –––"
@@ -73,6 +76,7 @@ create-random-branch:
 pr-status:
 	@gh pr view | cat | grep "title" 
 	@gh pr view | cat | grep "url" 
+	@echo "✅✅✅ PR created ✅✅✅"
 
 setup-pr: ## Update everything and setup the PR
 	@make merge-main