-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide pre-calculated linkage for the split heatmap #17
Conversation
And the use case:
|
Please don't feel pressured on this, there is no need to be hurry. The purpose of open-source is welcoming any communication and contributions then improve from that. I'll start reviewing soon. Thank you for your contributions! This is the first PR for Marsilea! |
I don't know how to edit the pull request, I checkout to your branch but cannot commit to it. The git just created a new branch instead. So I just opened a new PR #18. I made a few modifications, I placed I will merge all the code for now. But I will have to close this and merge the #18. If you know how to edit PR directly instead of creating a new one, please let me know. Thanks for your contributions again! Great job! |
* add `get_linkage` * Enables the linkage of add_dendrogram to be set to dictionary * Get linkage move to Deformation; Simplify setting order for split situation; The dendrogram now has a key attribute to track name. --------- Co-authored-by: liuzj <[email protected]>
Oh, I forgot to tick the box to allow maintainers to edit. If there's a next time, I'll be sure to tick it. |
fix #16 .
Hi @Mr-Milk , I apologize for not being able to complete this task until the weekend. I could not locate a section in the current code to save the
order
, hence I noted them in the_split_{axis}_group_order
attribute of the clusterboard and deform, respectively. I apologise if I have overlooked anything. I hope this code would be helpful.