-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust runout distance menu edit if FILAMENT_MOTION_SENSOR enabled. #27540
base: bugfix-2.1.x
Are you sure you want to change the base?
Conversation
Why would this be seen as an improvement? Most filament runout sensors will be much more than 10mm away from the extruder (extremely frequently more than 100mm), and whether you stop 0.1mm away from the absolute end of the filament, or 1.5mm, makes very little difference in "the grand scheme." |
If you have filament motion sensor, you would like to stop printing ASAP. |
In that case, you have no need for any distance measurement, because you're trying to "stop right now." I think the intent of the runout distance is for those of us who would prefer to know the filament is running out while there's still time to prep the next spool before the printer runs out; but then have the printer auto-pause before it ruins the print, if we haven't manually changed it yet. |
Morion sensor could have some reporting delay, i.e. there is delay between actual motion and detection, so you need some tolerance. Anyway Marlin has only one distance, and you can't set large for runout and small for morion.Look at BTT SFS documentation for example.
|
Ok, so if using a motion-detector, just set length to 1mm and be done, if that is your worry. |
Exactly. And if you need distance about 1-2mm it's better to have precision like 0.1 and also small range.
|
but you said you have no ability to use the precision (so no benefit), and by reducing the range you would completely destroy a very useful feature for everyone with microswitch runout sensors (so major detriment). |
I reduce range only if motion sensor is enabled. For runout sensor nothing changes.
|
Ok, the new change is fine for my purposes. |
Currently I use 2.4mm. I started from 2.0, and increased it due to false detection. |
|
Exactly
Yes, but it's another issue. |
When FILAMENT_MOTION_SENSOR is enabled increase runout edit precision to 0.1mm and reduce maximum to 10mm.