forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-40139 #301
Open
MarinhoFeliphe
wants to merge
372
commits into
master
Choose a base branch
from
LPD-40139
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LPD-40139 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
…layout item has 'useCustomName' enabled
MarinhoFeliphe
force-pushed
the
LPD-40139
branch
from
October 28, 2024 15:07
8b0e8f9
to
cbdfce2
Compare
…since now those tests are assigned to Triage Team
…registering the service
# breaking ## What modules/apps/object/object-service/src/main/java/com/liferay/object/service/impl/ObjectDefinitionLocalServiceImpl.java The addCustomObjectDefinition and updateCustomObjectDefinition methods now receive a new parameter called className ## Why This modification is required to allow importing object definitions into other environments while preserving the original class name, ensuring that old references are not broken. ---- # breaking ## What modules/apps/object/object-service/src/main/java/com/liferay/object/service/impl/ObjectDefinitionServiceImpl.java The addCustomObjectDefinition and updateCustomObjectDefinition methods now receive a new parameter called className ## Why This modification is required to allow importing object definitions into other environments while preserving the original class name, ensuring that old references are not broken. ----
…ame from the database
… if a user meets the assignment criteria
MarinhoFeliphe
force-pushed
the
LPD-40139
branch
from
October 29, 2024 17:47
cbdfce2
to
ce62a5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.