forked from liferay/liferay-portal
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPD-35167 #297
Open
MarinhoFeliphe
wants to merge
19
commits into
master
Choose a base branch
from
LPD-35167
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
LPD-35167 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the object definition 2 is published so put those trees under the same root object definition that is the object definition that is being published
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
MarinhoFeliphe
force-pushed
the
LPD-35167
branch
from
September 25, 2024 21:07
24951f0
to
98d3e69
Compare
…ge relationships related to the node to be published can belongs to a tree so those trees have to be combined
MarinhoFeliphe
force-pushed
the
LPD-35167
branch
from
September 25, 2024 21:11
98d3e69
to
e1d0df7
Compare
…ublished or draft
… trees into one in that process
…tion 1 when binding
…ree as a parent so it will becomes the root
…tus of object definiton 1 it should not be the root, instead the root should be the object definition 1 because they will be bind as a root
…raft tree into a tree that is published, it should be a child of this published tree and the tree he was root should be recalculated
MarinhoFeliphe
force-pushed
the
LPD-35167
branch
from
September 26, 2024 20:28
eb19c21
to
284d0f4
Compare
… because it is called first, the root object definition id will never be 0 at this point because the bind method always will set a root object definition id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.