MDEV-35578 innodb_gis.rtree_debug fails on mac #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-35578
branch
from
d4567ed to
c03e9a8
Compare
DaveGosselin-MariaDB
changed the title
strerror_s on Linux will, for unknown error codes, display 'Unknown error <codenum>' and our tests are written with this assumption. However, on macOS, sterror_s returns 'Unknown error: <codenum>' in the same case, which breaks tests. Make my_strerror consistent across the platforms by removing the ':' when present.
DaveGosselin-MariaDB
force-pushed
the
10.5-mdev-35578
branch
from
c03e9a8 to
91284ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strerror_s on Linux will, for unknown error codes, display 'Unknown error ' and our tests are written with this assumption. However, on macOS, sterror_s returns 'Unknown error: ' in the same case, which breaks tests. Make my_strerror consistent across the platforms by removing the ':' when present.