MDEV-35512 remove all RPM compat packages #3666
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The end of life of SLES 12 combined with the EOL for Centos/RHEL 7 marks a happy time in our distribution maintaince where we can drop all RPM compat packages. They where only needed for distros that we released at the time of MariaDB-10.1. All those have finally gone EOL. Horray!
grooverdan
added a commit
to grooverdan/mariadb-buildbot
that referenced
this pull request
Nov 27, 2024
RPM compat files aren't needed anywhere anymore. This will wait until MariaDB/server#3666 is merged up before merging into production. The only that was using it, RHEL8 (not s390x), was incorrect.
vuvova
approved these changes
Nov 27, 2024
|
actually, code-wise it's, obviously, fine. But let's wait a bit with this. Users could have a closed-source app linked against an old MySQL/MariaDB version. And 10.5 was GA for 4 years, may be it's not a good idea to start removing packages there |
|
@vuvova So then let's target this change to 10.6? That way we can close the issue. |
cvicentiu
added
the
MariaDB Foundation
|
we will close this issue. Eventually. See MDEV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The end of life of SLES 12 combined with the
EOL for Centos/RHEL 7 marks a happy time in
our distribution maintenance where we can drop
all RPM compat packages.
They where only needed for distros that
we released at the time of MariaDB-10.1.
All those have finally gone EOL. Hooray!
Release Notes
There are no more MariaDB-compat packages. Applications that linked to libmysqlclient.so.18.0.0 should have been updated by virtue of obsolescence.
How can this PR be tested?
Good logic on why they existing to start with.
We shouldn't have been releasing them for RHEL8. And nothing else was carrying them.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check