[pull] main from facebook:main #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: GitHub commits: facebook/buck2-prelude@12cb622 facebook/fb303@65e52b0 facebook/fbthrift@bf6f866 facebook/folly@c5aa5c4 facebook/mvfst@56b8e5d facebook/proxygen@9987143 facebook/wangle@fbbf256 facebookexperimental/rust-shed@d16d726 facebookincubator/fizz@f7c5fe7 Reviewed By: bigfootjon fbshipit-source-id: 27a78131f323d2e7ca60a4b2b700c8c3eb8a552f
Summary: GitHub commits: facebook/buck2-prelude@ca3eee1 facebook/fb303@5dc6f2d facebook/fbthrift@45ccdae facebook/folly@4bab8ad facebook/mvfst@2f7b7ff facebook/proxygen@da4a0f5 facebook/wangle@e22047b facebookexperimental/edencommon@00cd262 facebookexperimental/rust-shed@3d6bc1e facebookincubator/fizz@d4cd807 Reviewed By: zpao fbshipit-source-id: 8df80ba83dc828058423642b46210388f307acee
Summary: GitHub commits: facebook/buck2-prelude@b3ba9de facebook/fb303@88f9a1f facebook/fbthrift@8296c41 facebook/folly@475b862 facebook/mvfst@50d641d facebook/proxygen@a5251dc facebook/wangle@b24486b facebookexperimental/edencommon@1101bf4 facebookexperimental/rust-shed@814b4ea facebookincubator/fizz@6e2a75d Reviewed By: zpao fbshipit-source-id: ad0a059fb49f4c41bb47eff7b9c2e007ba2e8042
Summary: X-link: facebookincubator/zstrong#949 libgpiod is used by GpioLine.cpp but has never been needed in OSS before, adding this library to the CMake manifests to enable that. Reviewed By: paulcruz74 Differential Revision: D60934748 fbshipit-source-id: 8c705b3ffd3eb611ef96a3df95bbb7d70dd7f86d
Summary: X-link: facebookincubator/zstrong#950 Adds the ability to use GPIO lines for presence detection. Utilizes the GpioLine library from fboss lib. Reviewed By: kimdo8736 Differential Revision: D60946559 fbshipit-source-id: ce52d96e8cdcb1aa3e0bb385f1ef502185aaa33f
Summary: GitHub commits: facebook/buck2-prelude@2e3216e facebook/fb303@b9f3764 facebook/fbthrift@5aedc9a facebook/folly@47d9798 facebook/mvfst@bc38647 facebook/proxygen@520c30b facebook/wangle@def136c facebookexperimental/edencommon@518260d facebookexperimental/rust-shed@1046243 facebookincubator/fizz@861a453 Reviewed By: zpao fbshipit-source-id: fb8e4d7bc05450ac11d87c491b71519e6d926f1c
Summary: GitHub commits: facebook/buck2-prelude@1b94ead facebook/fb303@fd570a1 facebook/fbthrift@65946a2 facebook/folly@10dfe0d facebook/mvfst@3277f23 facebook/proxygen@0080618 facebook/wangle@e2fc511 facebookexperimental/edencommon@7e960b9 facebookexperimental/rust-shed@e216676 facebookincubator/fizz@15056ef Reviewed By: zpao fbshipit-source-id: 9d33e9a745397756791c4afdd85647c88a05bc9d
Summary: GitHub commits: facebook/buck2-prelude@1a4bffc facebook/fb303@f3b9d84 facebook/fbthrift@952a4a9 facebook/folly@a2aae6d facebook/mvfst@355c664 facebook/proxygen@bc3da98 facebook/wangle@ca9975b facebookexperimental/edencommon@954e260 facebookexperimental/rust-shed@328035f facebookincubator/fizz@30dd5ba Reviewed By: zpao fbshipit-source-id: 46b1af7ab1b825d89a56f8fd43a41d058ead8514
Summary: GitHub commits: facebook/fb303@91884fd facebook/fbthrift@ed28cf3 facebook/folly@31a4de6 facebook/mvfst@22ed073 facebook/proxygen@eeb1384 facebook/wangle@9d2cb81 facebookexperimental/edencommon@6ce07c4 facebookexperimental/rust-shed@83d7326 facebookincubator/fizz@942c031 Reviewed By: zpao fbshipit-source-id: 6a5daa7c4434e6a7bc5b6bd41e21140ead3d747d
Summary: GitHub commits: facebook/buck2-prelude@78df678 facebook/fb303@b3f7596 facebook/fbthrift@a591631 facebook/mvfst@84363ea facebook/proxygen@91e0a67 facebook/wangle@26b29a8 facebookexperimental/edencommon@1adedfb facebookexperimental/rust-shed@35eb2e9 facebookincubator/fizz@dc5a257 Reviewed By: zpao fbshipit-source-id: 9b9a2f0552fdaa8ab25f02b77ea43e8ef3db1201
Summary: This benchmarks various functions that convert decimal values in string representation to IEEE-754 double representation. These benchmarks `std::strtof`, `std::strtof` with a copy (needed for non-c-strings), `std::strtofl` with the C locale (for locale-indepent processing), `std::from_chars`, libdouble-conversion, and libfast_float. The functions are benchmarked on different inputs. There is input that is hardcoded values in decimal and exponentional notation. There is randomly generated values in the double space range. There is also inputs for single and double digit ints. As well as percentages. Note that `std::from_chars`, which on platform010/libstdc++ v11 uses `strtof` + `uselocale` [0]. libstdc++ v12 uses fast float[2]. 0: gcc-mirror/gcc@932fbc8 1: gcc-mirror/gcc@490e230#diff-d3c32d9c9c566f7f3888d150c6448428ea194170146a1a166917ba45b1252187 Reviewed By: yfeldblum, Orvid Differential Revision: D61356955 fbshipit-source-id: 6ec21b602b08505d946551dda49a35402bee7dae
Summary: GitHub commits: facebook/buck2-prelude@b5adb8a facebook/fb303@5d0f494 facebook/fbthrift@8d5f0d1 facebook/folly@9ff5005 facebook/mvfst@8fb4204 facebook/proxygen@ec135fe facebook/wangle@670a6da facebookexperimental/edencommon@a5b190f facebookexperimental/rust-shed@5be001d facebookincubator/fizz@2c5b748 Reviewed By: bigfootjon fbshipit-source-id: 332e25085d24e153b34c183d54a7f73824d8f205
Summary: X-link: facebookincubator/zstrong#944 https://github.com/facebook/mcrouter currently uses a legacy autotools-based build system, which forces third parties to rely on a collection of scripts hosted in the repository to build it with all required dependencies. This is brittle and has lead to many issue reports about build problems. In facebook/mcrouter#449, I've prepared a working CMake-based build system for mcrouter that could replace the legacy autotools setup. This patch adds the necessary manifests for mcrouter and its ragel dependency so that fbcode_builder itself will be setup for the repo without having to do it in the PR. X-link: facebook/folly#2268 Reviewed By: yfeldblum Differential Revision: D60537337 Pulled By: Orvid fbshipit-source-id: ed73693d4af93acc3b8e996a7c61d0090075949f
Summary: GitHub commits: facebook/buck2-prelude@e021801 facebook/fb303@056848f facebook/fbthrift@3b011c4 facebook/folly@ec50ab1 facebook/mvfst@e5d4ad6 facebook/proxygen@ce362e9 facebook/wangle@64f416d facebookexperimental/edencommon@b2bc0ac facebookexperimental/rust-shed@af731c0 facebookincubator/fizz@578f236 Reviewed By: bigfootjon fbshipit-source-id: 2a27dca6f3e30555ad8687c5609f9070b370ff6f
Summary: GitHub commits: facebook/buck2-prelude@e597754 facebook/fb303@1e29581 facebook/fbthrift@70bcc50 facebook/folly@98267c7 facebook/mvfst@52c9502 facebook/proxygen@d662d03 facebook/wangle@92d2767 facebookexperimental/edencommon@f01150c facebookexperimental/rust-shed@70f142b facebookincubator/fizz@bb12678 Reviewed By: bigfootjon fbshipit-source-id: b8b101296c0a06cb2790f3d5ce836e2b04437818
Summary: libfast-float-dev only exists on Ubuntu 24.04 and newer, causing build failures on older releases. X-link: facebook/folly#2283 Reviewed By: yfeldblum Differential Revision: D61622213 Pulled By: Orvid fbshipit-source-id: ea683431874d711f8e693b2dd6607cb36f5d8adf
Summary: In the next diff we no longer have a valid reference to return. Gonna change this to return by value. The reason is that we are no longer gonna be able to return the value directly from a stored future. We need to have a seperate future that we can block on for each wait call. This means creating a new future for each call. And then returning the value from the newly created future. This means the future we return the value from might get destroyed after the call to this method. Thus the value will outlive the future it's from. There are maybe some things we could do to prevent having to return by value instead of reference. But all the ideas I come up with are quite complicated. This call expects to be "slow" anyways since it blocks waiting for the pid info to be ready. So one extra copy on this path is not bad. There are a few callers of this. We can remve a copy from these and replace them with moves now that the returned value is owned. Callers: - [no update needed] https://www.internalfb.com/code/fbsource/[cc7496c5eba48918a08d7ac091ae154e75f9470e]/fbcode/eden/common/utils/test/ProcessInfoCacheTest.cpp?lines=123%2C131-132%2C135%2C138%2C171%2C201 - [updated] https://www.internalfb.com/code/fbsource/[cc7496c5eba48918a08d7ac091ae154e75f9470e]/fbcode/eden/fs/service/EdenServer.cpp?lines=2517 - [updated] https://www.internalfb.com/code/fbsource/[cc7496c5eba48918a08d7ac091ae154e75f9470e]/fbcode/watchman/Client.cpp?lines=285 - [no update needed] https://www.internalfb.com/code/fbsource/[cc7496c5eba48918a08d7ac091ae154e75f9470e]/fbcode/watchman/main.cpp?lines=117 Reviewed By: MichaelCuevas Differential Revision: D61478484 fbshipit-source-id: fa3f82efb328b37ec7e19355ea835881b74948c2
Summary: I wanna log the client for all requests so we can get a better understanding of Watchman clients. So I am gonna want the pid for all clients not just daemon clients. Moving the pid into the generic client class (from the daemon client class where it is now) so I can use the pid in all cases. Reviewed By: MichaelCuevas Differential Revision: D61480179 fbshipit-source-id: b9f44209063bae373bf1e1f54b7354dd2f0c791c
Summary: As we consider potential future options for Watchman, it's helpful to know who the watchman clients are. And how many requests they are sending us. Adds the command name of the client process so we can keep track of who is calling us. Planning to decrease retention on this column to 1 week, so we don't run out of capacity. Reviewed By: MichaelCuevas Differential Revision: D61480221 fbshipit-source-id: 4b4aa3e44de5b0dbbfe49e753113ab3a92a7e465
Summary: GitHub commits: facebook/buck2-prelude@4fd779f facebook/fb303@013ca78 facebook/fbthrift@1b63511 facebook/folly@dccbd05 facebook/mvfst@d07f3ba facebook/proxygen@b7236d6 facebook/wangle@9ffabe4 facebookexperimental/edencommon@b165bb6 facebookexperimental/rust-shed@5628e1b facebookincubator/fizz@412da7a Reviewed By: bigfootjon fbshipit-source-id: e53f596b91389827701dac713374736bc685d323
Summary: GitHub commits: facebook/buck2-prelude@b797592 facebook/fb303@475d419 facebook/fbthrift@c82427f facebook/folly@8bbaec8 facebook/mvfst@458b5c1 facebook/proxygen@c00aaa4 facebook/wangle@61c45e3 facebookexperimental/edencommon@78d8e3f facebookexperimental/rust-shed@3a0abd6 facebookincubator/fizz@b515b64 Reviewed By: bigfootjon fbshipit-source-id: b84f9a77c2cf7eb3c4af35d5da21f56189e06265
Summary: GitHub commits: facebook/fb303@6bd044d facebook/fbthrift@88ec5c7 facebook/folly@0ee5ecb facebook/mvfst@a93f27c facebook/proxygen@3862ef5 facebook/wangle@706aa48 facebookexperimental/edencommon@81d9eb1 facebookexperimental/rust-shed@6dfa306 facebookincubator/fizz@f22ef2d Reviewed By: bigfootjon fbshipit-source-id: 228e8a7de69a96c7b41b9d570b672bee40e73cfc
Summary: GitHub commits: facebook/buck2-prelude@64135f5 facebook/fb303@4a1d8db facebook/fbthrift@3424a17 facebook/folly@67c3f7d facebook/mvfst@867308e facebook/proxygen@4551cf6 facebook/wangle@de284ac facebookexperimental/edencommon@c741e96 facebookexperimental/rust-shed@6028e26 facebookincubator/fizz@66dcf40 Reviewed By: bigfootjon fbshipit-source-id: f08aea923a4640378d314f6b0314581613c098ee
Summary: GitHub commits: facebook/buck2-prelude@b6cea50 facebook/fb303@10d7e25 facebook/fbthrift@70cfe2d facebook/folly@5eb3a76 facebook/mvfst@5f74df1 facebook/proxygen@0aede00 facebook/wangle@fbd1601 facebookexperimental/edencommon@28dca0f facebookexperimental/rust-shed@de20508 facebookincubator/fizz@a1c51fc Reviewed By: ajb85 fbshipit-source-id: 702bb98fd2ca61c8e60aa551768f1807fdcff42b
Summary: I added client logging to the Watchman `dispatch_command` event. Watchman has a few different types of scuba events: - query_execute - sync_to_now - full_crawl - clock_test - saved_state - dropped - age_out Some of these events are associated with a specific client request, so I would like to include client information there as well. There are a few that are not related to a specific client event: - full_crawl - clock_test - dropped - age_out So I only intend to add client information to - query_execute - sync_to_now - saved_state Going to move these client attributes to the more generically used MetadataEventData instead of being on the event types for each event to avoid copy paste. Reviewed By: genevievehelsel Differential Revision: D61684457 fbshipit-source-id: bf4765780cfd09c7ff5a0a3f0ef56dcc10f58dfd
Reviewed By: fanzeyi, dtolnay Differential Revision: D61876827 fbshipit-source-id: 54223a5741114f76152c981ef2bce472970aa8a9
Summary: forgot a move in D61684457 when I did the refactor to add tests so this is an unnessecary copy. Reviewed By: genevievehelsel Differential Revision: D61881277 fbshipit-source-id: dc191a1f0425ed199ad28a2b08ea23609130a57c
Summary: GitHub commits: facebook/buck2-prelude@fa3ccd6 facebook/fb303@ab158c1 facebook/fbthrift@9a22772 facebook/folly@ce5edfb facebook/mvfst@777bdab facebook/proxygen@86fe7a0 facebook/wangle@d732d18 facebookexperimental/edencommon@c2afc74 facebookexperimental/rust-shed@c13fb9e facebookincubator/fizz@8e08034 Reviewed By: ajb85 fbshipit-source-id: e337ce0af62b0a830e561585dc839e699d7dac0f
Summary: GitHub commits: facebook/buck2-prelude@cd07b63 facebook/fb303@c0c3fe0 facebook/fbthrift@970cc94 facebook/folly@a2be2eb facebook/mvfst@b09f243 facebook/proxygen@3b09888 facebook/wangle@45535c5 facebookexperimental/edencommon@1e714e7 facebookexperimental/rust-shed@0e5b012 facebookincubator/fizz@9a7bd7f Reviewed By: zpao fbshipit-source-id: d45f1c656cb38b81be235177b8824008a15810aa
Summary: GitHub commits: facebook/buck2-prelude@262d198 facebook/buck2-shims-meta@ca687cb facebook/fb303@0116433 facebook/fbthrift@e651ddb facebook/folly@abf77ba facebook/mvfst@7255535 facebook/proxygen@3664efa facebook/wangle@c2544d3 facebookexperimental/edencommon@4ed8442 facebookexperimental/rust-shed@8857c04 facebookincubator/Facebook-Pixel-for-Wordpress@10ce527 facebookincubator/fizz@680fbab Reviewed By: JurjenLelifeld fbshipit-source-id: c19968a133fb14c8bc5756e6e90051204fc5c606
Summary: GitHub commits: facebook/buck2-prelude@6c1818e facebook/fb303@f3589ff facebook/fbthrift@0993c97 facebook/folly@e5ffaf6 facebook/mvfst@4dea551 facebook/proxygen@3ab47a2 facebook/wangle@93c3db7 facebookexperimental/edencommon@82f537e facebookexperimental/rust-shed@5200540 facebookincubator/fizz@7875ccf Reviewed By: JurjenLelifeld fbshipit-source-id: d882ac329b29f05c308e22c37e336b25aeacd29b
Summary: GitHub commits: facebook/buck2-prelude@bd95c36 facebook/fb303@27d167e facebook/fbthrift@1ecfb2f facebook/folly@62baa6b facebook/mvfst@842702b facebook/proxygen@0ba72ed facebook/wangle@a4a0969 facebookexperimental/edencommon@7aa805e facebookexperimental/rust-shed@9cb7209 facebookincubator/fizz@747d865 Reviewed By: JurjenLelifeld fbshipit-source-id: ac0eae249098bc079daaca3275d7aa7b9b56ad3a
Summary: Remove facebook-hte-PortabilityInclude-{gtest,gmock} clang-tidy lints because they are no longer needed now that windows UCRT declares its own posix functions.
Reviewed By: Jason-M-Fugate
Differential Revision: D67056931
fbshipit-source-id: d57afba50577191c72b0cd07dc96a538e1ecc8c1
Summary: GitHub commits: facebook/buck2-prelude@851d3f0 facebook/buck2-shims-meta@b74887e facebook/fb303@85e3cc7 facebook/fbthrift@8c09d66 facebook/folly@d6c2c77 facebook/mvfst@8242617 facebook/proxygen@7ed1d57 facebook/wangle@5f97713 facebookexperimental/edencommon@c880f31 facebookexperimental/rust-shed@e1c7e12 facebookincubator/fizz@d869e77 Reviewed By: JurjenLelifeld fbshipit-source-id: 7001752fe3709ab6fcea8a50456b5d22d3e78ce2
Summary: GitHub commits: facebook/fb303@591c635 facebook/fbthrift@6b0b4c8 facebook/folly@1acde9a facebook/mvfst@7899ed3 facebook/proxygen@a0d9fda facebook/wangle@2aad803 facebookexperimental/edencommon@acaec87 facebookexperimental/rust-shed@bf274fd facebookincubator/fizz@964ccaf Reviewed By: JurjenLelifeld fbshipit-source-id: 3de368826b835847d0a4e3022793a09c809aae44
Summary: GitHub commits: facebook/buck2-prelude@27ee7ff facebook/fb303@bd331a2 facebook/fbthrift@b00e4f5 facebook/folly@132d899 facebook/mvfst@291284e facebook/proxygen@3633c7a facebook/wangle@8aa1449 facebookexperimental/edencommon@72f60de facebookexperimental/rust-shed@729b885 facebookincubator/fizz@3b75fe8 Reviewed By: bigfootjon fbshipit-source-id: cdd812f64bf72f2ae0b1090bc5db77f597620bb6
Summary: GitHub commits: facebook/buck2-prelude@1bd21b2 facebook/buck2-shims-meta@7e64245 facebook/fb303@571ecc7 facebook/fbthrift@386acea facebook/folly@264b8b7 facebook/mvfst@1932fce facebook/proxygen@b6168bc facebook/wangle@f71e81c facebookexperimental/edencommon@d7e8771 facebookexperimental/rust-shed@01bb7f3 facebookincubator/Facebook-Pixel-for-Wordpress@583009c facebookincubator/fizz@b9f6a81 Reviewed By: bigfootjon fbshipit-source-id: c296aadff0a3e095a854edf0f5d67d7a547f86bb
Summary: Enable more features that are disabled by default and update call sites. Reviewed By: opsound, jasonwhite Differential Revision: D66275420 fbshipit-source-id: 4969045de7751c7d16b6ed5c7411f04077eb0ddc
Summary: GitHub commits: facebook/buck2-prelude@b6848d8 facebook/fb303@e2393b1 facebook/fbthrift@1ee3bf9 facebook/folly@8a0687a facebook/mvfst@30df3f5 facebook/proxygen@944b207 facebook/wangle@a9b8459 facebookexperimental/edencommon@669b623 facebookexperimental/rust-shed@c81e677 facebookincubator/fizz@0e2074f Reviewed By: bigfootjon fbshipit-source-id: e50fc6db38d8c006c8b5a654e361f8620a8a0084
Summary: GitHub commits: facebook/buck2-prelude@2b5a01c facebook/fb303@7dfdaf0 facebook/fbthrift@addb3d0 facebook/folly@ad12236 facebook/mvfst@a172fbf facebook/proxygen@7dc494e facebook/wangle@b8dfd8f facebookexperimental/edencommon@ea54f73 facebookexperimental/rust-shed@184e80b facebookincubator/fizz@af44b6a Reviewed By: bigfootjon fbshipit-source-id: a97180cf508fd7127d0189d11b298a0d6fe4e1b3
Summary: GitHub commits: facebook/buck2-prelude@6e8e562 facebook/fb303@f863e5c facebook/fbthrift@4662bb3 facebook/folly@819b4c4 facebook/mvfst@d976163 facebook/proxygen@f03a4d5 facebook/wangle@7beae5d facebookexperimental/edencommon@f6f881b facebookexperimental/rust-shed@24ff797 facebookincubator/fizz@e0042c4 Reviewed By: bigfootjon fbshipit-source-id: ad6e0e8ea5e9b0859fd9b8e912cc4caf97f43cfd
Summary: GitHub commits: facebook/fb303@4d6c19b facebook/fbthrift@8c617d5 facebook/folly@10713dd facebook/mvfst@0948f93 facebook/proxygen@8e05f70 facebook/wangle@ae5c7ba facebookexperimental/edencommon@e8f21e9 facebookexperimental/rust-shed@f6585ee facebookincubator/fizz@73a0aca Reviewed By: ckwalsh fbshipit-source-id: 35fbd4941654da0387bf0c68eb48c53b24a63da5
Summary: GitHub commits: facebook/fb303@ecd70a9 facebook/fbthrift@bbcb19a facebook/mvfst@227cd9e facebook/proxygen@0e13320 facebook/wangle@cbb4f07 facebookexperimental/edencommon@c4a0920 facebookexperimental/rust-shed@927c754 facebookincubator/fizz@707f9c2 Reviewed By: ckwalsh fbshipit-source-id: cd199a2c8e1c34e64b4d0c868e9b6c7b860d636a
Summary: GitHub commits: facebook/fb303@9fb53da facebook/fbthrift@da6df76 facebook/mvfst@8a08b8e facebook/proxygen@82fcabe facebook/wangle@b343999 facebookexperimental/rust-shed@c30cdfb Reviewed By: ckwalsh fbshipit-source-id: f183d37b8fa37baab320a82817a23b128d8b3c65
Summary: GitHub commits: facebook/buck2-prelude@6345e0b facebook/buck2-shims-meta@e40bd23 facebook/fb303@202563c facebook/fbthrift@50f3880 facebook/mvfst@2795a0d facebook/proxygen@13ca9bf facebookexperimental/rust-shed@4ec9f39 Reviewed By: ckwalsh fbshipit-source-id: 2d612c527379c1690053b9e52a8072526f819ca9
Summary: GitHub commits: facebook/buck2-shims-meta@5476ee7 facebook/fb303@10eda3e facebook/fbthrift@67546d1 facebook/folly@7a747a5 facebook/mvfst@686b40a facebook/proxygen@036313a facebook/wangle@fa6a371 facebookexperimental/rust-shed@8dd14bf facebookincubator/fizz@cd1db8a Reviewed By: ckwalsh fbshipit-source-id: a9901b0b829eecd71d3cfdff65ea6c131272e1c9
Summary: GitHub commits: facebook/fb303@64bdd77 facebook/fbthrift@b3faa6e facebook/folly@d83089f facebook/mvfst@57bf5ac facebook/proxygen@b93fda1 facebook/wangle@a2e9697 facebookexperimental/edencommon@317a3fa facebookexperimental/rust-shed@e587961 facebookincubator/fizz@aecd5c4 Reviewed By: ckwalsh fbshipit-source-id: 9599ea468448a3d4e2d386353edeba996900ae0f
Summary: GitHub commits: facebook/buck2-prelude@b4a7787 facebook/fb303@06c4cc4 facebook/fbthrift@a32053c facebook/folly@4dcc2ab facebook/mvfst@3eac9a6 facebook/proxygen@f4a2145 facebook/wangle@2a45a75 facebookexperimental/edencommon@336d8ad facebookexperimental/rust-shed@3d01a49 facebookincubator/fizz@76aad45 Reviewed By: ajb85 fbshipit-source-id: 8569d24fc820f98d5f5d27f492185c585811ff1a
Summary: X-link: facebookincubator/zstrong#1098 We have been manually syncing our builds when there is a change in builds of our dependencies (folly, thrift). This has been one of the major source of work in OSS maintenance. Migrating to getdeps will automatically sync the dependencies which means we only have to manage our own builds. NOTE: There is a dependency of getdeps on zlib which requires us to first run sudo dnf install -y zlib-devel before we successfully run getdeps. I don't think this should affect the OSS build as it is a getdeps dependency. Reviewed By: haowu14 Differential Revision: D65844211 fbshipit-source-id: 8e89e670cdec4a21ca7aba48ae58b5b72ddbf832
Summary: GitHub commits: facebook/buck2-prelude@5b7690f facebook/fb303@7bae662 facebook/fbthrift@fe35c04 facebook/folly@7fad06e facebook/mvfst@4e03dab facebook/proxygen@6b2dd9a facebook/wangle@c211074 facebookexperimental/edencommon@83710d2 facebookexperimental/rust-shed@ab32c71 facebookincubator/fizz@a07c7a7 Reviewed By: ajb85 fbshipit-source-id: a42b5c96dc14ba5dcdc043398ddb731dbdc79c07
Summary: GitHub commits: facebook/fb303@2f4b7f2 facebook/fbthrift@f1d7916 facebook/mvfst@02cf66d facebook/proxygen@6c34cb7 facebook/wangle@667ab81 facebookexperimental/edencommon@aa3979b facebookexperimental/rust-shed@4e11205 facebookincubator/fizz@916c919 Reviewed By: ajb85 fbshipit-source-id: ef3c89c08a21a3369f3420b45929c0636f9c0513
Summary: GitHub commits: facebook/fb303@ba55be5 facebook/fbthrift@0b9eb8d facebook/mvfst@86546b7 facebook/proxygen@6ab4360 facebook/wangle@b9e121d facebookexperimental/rust-shed@3c5713f Reviewed By: ajb85 fbshipit-source-id: eb15bc935135cc3fe0f802f6bc1a6330ffbd15f8
Summary: GitHub commits: facebook/fb303@eb8d4f7 facebook/fbthrift@ea577d5 facebook/proxygen@ed4dfc1 facebookexperimental/rust-shed@92a2ca3 Reviewed By: ajb85 fbshipit-source-id: 18528711e74e227d585dd498d4abbdc1c5648b76
Summary: # Context We are introducing EdenFS notifications to support scalable and ergonomic file system notifications for EdenFS mounts. # This Diff This diff introduces the concepts of included/excluded Suffixes to the getChangesV2 pipeline. The files returned from the API will always match any defined included suffixes, and never have any excluded suffixes. If a suffix is both included and excluded, then it is excluded. A suffix is defined as the substring that ends the string. As currently defined, a suffix could include content past the file extention, including the , eg for file.ext1.ext2, ex2, ext1.ext2, and file.ext1.ext2 are valid suffixes # Technical Details This diff creates the thrift definitions for the included/excluded suffix types # Discussion Points Reviewed By: jdelliot Differential Revision: D67613986 fbshipit-source-id: f18957a490d3095324d46046f57233bba92565aa
Summary: GitHub commits: facebook/buck2-prelude@d11a72d facebook/fbthrift@a22442c facebook/folly@1392864 facebookexperimental/rust-shed@61d5f20 Reviewed By: ajb85 fbshipit-source-id: aba9df1752eb7a9a63852128f55a867183cf680e
Summary: Mainly due to the need to have [`Error::from_boxed`](https://docs.rs/anyhow/1.0.95/anyhow/struct.Error.html#method.from_boxed) and stop using less ergonomic alternatives. Thankfully, this API comes in the latest [1.0.95](https://github.com/dtolnay/anyhow/releases/tag/1.0.95) Reviewed By: dtolnay Differential Revision: D67775008 fbshipit-source-id: b9c0d3ff169dbb69d4c8b96e378334b37d200fd2
Summary: GitHub commits: facebook/buck2-prelude@857917c facebook/buck2-shims-meta@83ff496 facebook/fb303@9a68b5b facebook/fbthrift@02ab389 facebook/folly@25759e9 facebook/mvfst@1724f61 facebook/proxygen@1da7dfa facebook/wangle@b257d47 facebookexperimental/edencommon@cee5877 facebookexperimental/rust-shed@78d6ad3 facebookincubator/fizz@8b3f516 Reviewed By: ajb85 fbshipit-source-id: 756047b10603daea1492f9844cbca9505d79974e
Summary: GitHub commits: facebook/buck2-prelude@f6d5eb4 facebook/fb303@02f1d02 facebook/fbthrift@1ccf706 facebook/folly@b5650df facebook/mvfst@ca032a4 facebook/proxygen@80fbd5a facebook/wangle@9389b37 facebookexperimental/edencommon@af2e8a3 facebookexperimental/rust-shed@f03882a facebookincubator/fizz@dea388b Reviewed By: ajb85 fbshipit-source-id: f7da6dfe747fc27b894d228e1432c3f90e911da3
Summary: GitHub commits: facebook/fb303@5a01c81 facebook/fbthrift@dd994f4 facebook/folly@7828768 facebook/mvfst@c0d459a facebook/proxygen@fe3bdfe facebook/wangle@c89914e facebookexperimental/edencommon@c4d142f facebookexperimental/rust-shed@e76c806 facebookincubator/fizz@3879c42 Reviewed By: ajb85 fbshipit-source-id: 3d83805cd27a2a78a8251986966dc4665dabba78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )