Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fix on media module #7

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Some fix on media module #7

wants to merge 23 commits into from

Conversation

voltan
Copy link

@voltan voltan commented Nov 25, 2019

No description provided.

Copy link
Owner

@Marc-pi Marc-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello,
no, it is unlinck, not media deletion ! please change back

@voltan
Copy link
Author

voltan commented Nov 25, 2019

hello,
no, it is unlinck, not media deletion ! please change back

Fixed,

Just I have a SQL problem on geoloc_latitude and geoloc_longitude, field type should be change, do you use it on your website? if no, I can remove them and add new field type

And what about asset table, I think it not used on media module

@Marc-pi
Copy link
Owner

Marc-pi commented Nov 25, 2019

Just I have a SQL problem on geoloc_latitude and geoloc_longitude, field type should be change, do you use it on your website? if no, I can remove them and add new field type

yes, you can, i do not use

asset

no, i don't have it, should be an orphean in mysql.sql file ! you can delete

src/Model/Doc/RowGateway.php Outdated Show resolved Hide resolved
@voltan
Copy link
Author

voltan commented Nov 26, 2019

tables and fields removed

@voltan
Copy link
Author

voltan commented Nov 26, 2019

Please still wait for more test by me before merge

@Marc-pi
Copy link
Owner

Marc-pi commented Nov 29, 2019

@voltan don't forget to add back fixed long/lat fields. Seems you deleted with no remplacement ! you wanted to change field type, no to delete them all

@voltan
Copy link
Author

voltan commented Nov 29, 2019

@voltan don't forget to add back fixed long/lat fields. Seems you deleted with no remplacement ! you wanted to change field type, no to delete them all

Its added, I use text format for save location, First I had plan to use point field type, but it need add to many changes on all of select / find / update and insert action ( I do all of them on my local ), but I was worried this change make some bugs, than I revert it and use text format

@voltan
Copy link
Author

voltan commented Nov 29, 2019

@Marc-pi I think this version ready for review/test and merge

@voltan
Copy link
Author

voltan commented Dec 8, 2019

Can you please check it @Marc-pi

@voltan
Copy link
Author

voltan commented Dec 15, 2019

Up :D @Marc-pi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants