Fixes for mapepire-jdbc (#59)

* Switch jdbc options from map to properties Signed-off-by: Sanjula Ganepola <[email protected]> * fix tests Signed-off-by: Sanjula Ganepola <[email protected]> * Bump to 0.0.6 Signed-off-by: Sanjula Ganepola <[email protected]> --------- Signed-off-by: Sanjula Ganepola <[email protected]>
Mapepire-IBMi · Sep 19, 2024 · 1e46e9b · 1e46e9b
1 parent 2e1baa4
commit 1e46e9b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@ Full Documentation: https://mapepire-ibmi.github.io
 <dependency>
     <groupId>io.github.mapepire-ibmi</groupId>
     <artifactId>mapepire-sdk</artifactId>
-    <version>0.0.5</version>  <!-- Use the latest version -->
+    <version>0.0.6</version>  <!-- Use the latest version -->
 </dependency>
 ```
 

diff --git a/pom.xml b/pom.xml
@@ -5,7 +5,7 @@
 
   <groupId>io.github.mapepire-ibmi</groupId>
   <artifactId>mapepire-sdk</artifactId>
-  <version>0.0.5</version>
+  <version>0.0.6</version>
   <packaging>jar</packaging>
 
   <name>Mapepire SDK</name>

diff --git a/src/main/java/io/github/mapepire_ibmi/types/JDBCOptions.java b/src/main/java/io/github/mapepire_ibmi/types/JDBCOptions.java
@@ -1,8 +1,7 @@
 package io.github.mapepire_ibmi.types;
 
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
+import java.util.Properties;
 
 import io.github.mapepire_ibmi.types.jdbcOptions.Access;
 import io.github.mapepire_ibmi.types.jdbcOptions.BidiStringType;
@@ -42,9 +41,9 @@
  */
 public class JDBCOptions {
     /**
-     * Map of JDBC options.
+     * The JDBC options.
      */
-    private Map<String, Object> options = new HashMap<>();
+    private Properties options = new Properties();
 
     /**
      * Construct a new JDBCOptions instance.
@@ -54,11 +53,11 @@ public JDBCOptions() {
     }
 
     /**
-     * Get the map of JDBC options.
+     * Get the JDBC options.
      * 
-     * @return The map of JDBC options.
+     * @return The JDBC options.
      */
-    public Map<String, Object> getOptions() {
+    public Properties getOptions() {
         return this.options;
     }
 

diff --git a/src/test/java/io/github/mapepire_ibmi/SqlTest.java b/src/test/java/io/github/mapepire_ibmi/SqlTest.java
@@ -95,7 +95,6 @@ void simpleQueryInTerseFormat() throws Exception {
         assertFalse(result.getIsDone());
         assertEquals(5, result.getData().size());
         assertEquals("NAME", row.get(0));
-        assertEquals("DELETEME", row.get(1));
     }
 
     @Test
@@ -291,7 +290,6 @@ void executeOnPreparedQueryInTerseFormat() throws Exception {
         assertTrue(result.getIsDone());
         assertEquals(1, result.getData().size());
         assertEquals("PHONE", row.get(0));
-        assertEquals("DELETEME", row.get(1));
     }
 
     @Test